Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 1434783002: Roll buildtools c2f259809d..4a95614772 (Closed)

Created:
5 years, 1 month ago by brettw
Modified:
5 years, 1 month ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll buildtools c2f259809d..4a95614772 In order to roll GN 6ac116d7ac..c51453e958 (r357182:r358852) and pick up the following changes: 782b1bc Support spaces in Mac GN build output names. ae483ee GN bootstrap fixes: c20901b Improve gn path command. 763cdd3 Fix //tools/gn/example on Linux: missing current_os and related vars R=dpranke@chromium.org TBR=dpranke@chromium.org CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:mac_chromium_gn_dbg;tryserver.chromium.win:win8_chromium_gn_dbg,win_chromium_gn_x64_rel Committed: https://chromium.googlesource.com/chromium/src/+/da81e95071cb7a84c8ac7003b3125831be240482

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
brettw
5 years, 1 month ago (2015-11-10 18:35:02 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1434783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1434783002/1
5 years, 1 month ago (2015-11-10 18:35:40 UTC) #3
Dirk Pranke
lgtm
5 years, 1 month ago (2015-11-10 18:59:48 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/92431)
5 years, 1 month ago (2015-11-10 20:24:23 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/da81e95071cb7a84c8ac7003b3125831be240482 Cr-Commit-Position: refs/heads/master@{#358892}
5 years, 1 month ago (2015-11-10 20:32:31 UTC) #7
brettw
5 years, 1 month ago (2015-11-10 20:32:54 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
da81e95071cb7a84c8ac7003b3125831be240482 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698