Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 1434773002: Bump DEPS to 0.1.5. (Closed)

Created:
5 years, 1 month ago by pquitslund
Modified:
5 years, 1 month ago
Reviewers:
keertip
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Bump DEPS to 0.1.5. Pulls in: * Added `prefer_is_not_empty` lint rule (#143). * Added `type_annotate_public_apis` lint rule (#24). * Added `avoid_as` lint rule (#145). * Fixed `non_constant_identifier_names` rule to special case underscore identifiers in callbacks. * Fix to escape `_`s in callback type validation (addresses false positives in `always_specify_types`) (#147). R=keertip@google.com Committed: https://github.com/dart-lang/sdk/commit/7468ed191d96da09167b126f78a0fa0591b0def2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
pquitslund
5 years, 1 month ago (2015-11-10 18:10:38 UTC) #2
keertip
lgtm
5 years, 1 month ago (2015-11-10 18:18:04 UTC) #3
pquitslund
5 years, 1 month ago (2015-11-10 18:20:59 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7468ed191d96da09167b126f78a0fa0591b0def2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698