tools/json_schema_compiler/cpp_type_generator.py - Issue 143473003: Generate ax enums from idl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/json_schema_compiler/cpp_type_generator.py

Issue 143473003: Generate ax enums from idl. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Caught Blink enum conversion bug! Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/json_schema_compiler/cpp_type_generator.py

diff --git a/tools/json_schema_compiler/cpp_type_generator.py b/tools/json_schema_compiler/cpp_type_generator.py

index d485b46c5cdea81ca443c564e34199efd8bfcd60..244cbda1fa54c7e900f9229b5217cc05f86cc0ec 100644

--- a/tools/json_schema_compiler/cpp_type_generator.py

+++ b/tools/json_schema_compiler/cpp_type_generator.py

@@ -64,8 +64,9 @@ class CppTypeGenerator(object):

e.g VAR_STRING

"""

- value = '%s_%s' % (self.FollowRef(type_).unix_name.upper(),

- cpp_util.Classname(enum_value.name.upper()))

+ value = cpp_util.Classname(enum_value.name.upper())

+ if not type_.cpp_omit_enum_type:

+ value = '%s_%s' % (self.FollowRef(type_).unix_name.upper(), value)

# To avoid collisions with built-in OS_* preprocessor definitions, we add a

# trailing slash to enum names that start with OS_.

if value.startswith("OS_"):

« no previous file with comments | « tools/json_schema_compiler/compiler.py ('k') | tools/json_schema_compiler/cpp_util.py » ('j') | no next file with comments »