tools/json_schema_compiler/cc_generator.py - Issue 143473003: Generate ax enums from idl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/json_schema_compiler/cc_generator.py

Issue 143473003: Generate ax enums from idl. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Caught Blink enum conversion bug! Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/json_schema_compiler/cc_generator.py

diff --git a/tools/json_schema_compiler/cc_generator.py b/tools/json_schema_compiler/cc_generator.py

index 68152b52f43f5338dc6379868292d1df556be72d..04d951b86fbbed44a3397c54defa0a85fd62326a 100644

--- a/tools/json_schema_compiler/cc_generator.py

+++ b/tools/json_schema_compiler/cc_generator.py

@@ -46,7 +46,7 @@ class _Generator(object):

.Append('#include "base/strings/string_number_conversions.h"')

.Append('#include "base/strings/utf_string_conversions.h"')

.Append('#include "%s/%s.h"' %

- (self._namespace.source_file_dir, self._namespace.unix_name))

+ (self._namespace.source_file_dir, self._namespace.short_filename))

.Cblock(self._type_helper.GenerateIncludes(include_soft=True))

.Append()

.Concat(cpp_util.OpenNamespace(self._cpp_namespace))

@@ -91,6 +91,7 @@ class _Generator(object):

(c.Concat(self._type_helper.GetNamespaceEnd())

.Cblock(cpp_util.CloseNamespace(self._cpp_namespace))

)

+ c.Append()

return c

def _GenerateType(self, cpp_namespace, type_):