Generate ax enums from idl.

tools/json_schema_compiler/h_generator.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from code import Code
 from model import PropertyType
 import cpp_util
 import schema_util
 
 class HGenerator(object):
@@ skipping 124 matching lines @@
 
     for type_ in self._namespace.types.values():
       ExpandType([], type_)
     return dependency_order
 
   def _GenerateEnumDeclaration(self, enum_name, type_):
     """Generate the declaration of a C++ enum.
     """
     c = Code()
     c.Sblock('enum %s {' % enum_name)
-    c.Append(self._type_helper.GetEnumNoneValue(type_) + ',')
     for value in type_.enum_values:
       c.Append(self._type_helper.GetEnumValue(type_, value) + ',')
+    c.Append(self._type_helper.GetEnumNoneValue(type_))
     return c.Eblock('};')
 
   def _GenerateFields(self, props):
     """Generates the field declarations when declaring a type.
     """
     c = Code()
     needs_blank_line = False
     for prop in props:
       if needs_blank_line:
         c.Append()
@@ skipping 41 matching lines @@
         )
     elif type_.property_type == PropertyType.STRING:
       if generate_typedefs:
         if type_.description:
           c.Comment(type_.description)
         c.Append('typedef std::string %(classname)s;')
     elif type_.property_type == PropertyType.ENUM:
       if type_.description:
         c.Comment(type_.description)
       c.Sblock('enum %(classname)s {')
-      c.Append('%s,' % self._type_helper.GetEnumNoneValue(type_))
       for value in type_.enum_values:
         c.Append('%s,' % self._type_helper.GetEnumValue(type_, value))
+      # Add any non-explicit enum values last.
+      c.Append('%s,' % self._type_helper.GetEnumNoneValue(type_))

[not at google - send to devlin, 2014/01/23 00:04:40]

Explain this a bit more (why you need it last). I can see why but without the
context of this patch (making the enums match up with some other enum list) it
seems arbitrary.

also, same comment needed where you changed it above.

[David Tseng, 2014/01/23 00:31:43]

This is mostly paranoia on my part because of the various comments stating to
keep enums in sync. I'm not sure if we ever cast from a Blink enum role to a
Chrome specific one.

Added comment for the other instance.

       # Top level enums are in a namespace scope so the methods shouldn't be
       # static. On the other hand, those declared inline (e.g. in an object) do.
       maybe_static = '' if is_toplevel else 'static '
       (c.Eblock('};')
         .Append()
         .Append('%sstd::string ToString(%s as_enum);' %
                     (maybe_static, classname))
         .Append('%s%s Parse%s(const std::string& as_string);' %
                     (maybe_static, classname, classname))
       )
@@ skipping 166 matching lines @@
       .Append('}  // namespace Results')
     )
     return c
 
   def _GenerateParams(self, params):
     """Builds the parameter list for a function, given an array of parameters.
     """
     if self._generate_error_messages:
       params += ('base::string16* error = NULL',)
     return ', '.join(str(p) for p in params)