Issue 143473002: De-hardcode link concurrency for Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 143473002: De-hardcode link concurrency for Windows. (Closed)

Created:
6 years, 11 months ago by Sébastien Marchand

Modified:
6 years, 11 months ago

Reviewers:
robertshield, scottmg

CC:
gyp-developer_googlegroups.com

Base URL:
http://gyp.googlecode.com/svn/trunk/

Visibility:
Public.

De-hardcode link concurrency for Windows. it's not needed anymore as we're using the GYP_USE_SEPARATE_MSPDBSRV flag on the Windows builders. BUG=333000, 335607 R=scottmg@chromium.org, robertshield@chromium.org Committed: https://code.google.com/p/gyp/source/detail?r=1842

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -4 lines)			Patch
	M	pylib/gyp/generator/ninja.py	View		1 chunk	+1 line, -4 lines	0 comments	Download

Total messages: 4 (0 generated)

scottmg

lgtm (I missed the other restarts, everything went ok after the \ fix?)

6 years, 11 months ago (2014-01-20 16:45:36 UTC) #2

Sébastien Marchand

Thanks, committing. The bots have been running for 2 days without the GYP_LINK_CONCURRENCY_MAX flag and ...

6 years, 11 months ago (2014-01-20 16:52:18 UTC) #3

Sébastien Marchand

6 years, 11 months ago (2014-01-20 20:47:39 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r1842 (presubmit successful).