Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tests/standalone/bytedata_test.dart

Issue 14347003: Change test to use identical instead of '===' which is deprecated. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/standalone/bytedata_test.dart
===================================================================
--- tests/standalone/bytedata_test.dart (revision 21691)
+++ tests/standalone/bytedata_test.dart (working copy)
@@ -38,10 +38,10 @@
Expect.equals(expected_value_le, value);
value = bd.getInt16(0, Endianness.HOST_ENDIAN);
if (host_is_little_endian) {
- Expect.isTrue(Endianness.HOST_ENDIAN === Endianness.LITTLE_ENDIAN);
+ Expect.isTrue(identical(Endianness.HOST_ENDIAN, Endianness.LITTLE_ENDIAN));
Expect.equals(expected_value_le, value);
} else {
- Expect.isTrue(Endianness.HOST_ENDIAN === Endianness.BIG_ENDIAN);
+ Expect.isTrue(identical(Endianness.HOST_ENDIAN, Endianness.BIG_ENDIAN));
Expect.equals(expected_value_be, value);
}
@@ -52,10 +52,10 @@
value = bd.getUint16(0, Endianness.LITTLE_ENDIAN);
Expect.equals(0xf2f1, value);
if (host_is_little_endian) {
- Expect.isTrue(Endianness.HOST_ENDIAN === Endianness.LITTLE_ENDIAN);
+ Expect.isTrue(identical(Endianness.HOST_ENDIAN, Endianness.LITTLE_ENDIAN));
Expect.equals(0xf2f1, value);
} else {
- Expect.isTrue(Endianness.HOST_ENDIAN === Endianness.BIG_ENDIAN);
+ Expect.isTrue(identical(Endianness.HOST_ENDIAN, Endianness.BIG_ENDIAN));
Expect.equals(0xf1f2, value);
}
@@ -69,10 +69,10 @@
value = bd.getInt32(0, Endianness.LITTLE_ENDIAN);
Expect.equals(expected_value_le, value);
if (host_is_little_endian) {
- Expect.isTrue(Endianness.HOST_ENDIAN === Endianness.LITTLE_ENDIAN);
+ Expect.isTrue(identical(Endianness.HOST_ENDIAN, Endianness.LITTLE_ENDIAN));
Expect.equals(expected_value_le, value);
} else {
- Expect.isTrue(Endianness.HOST_ENDIAN === Endianness.BIG_ENDIAN);
+ Expect.isTrue(identical(Endianness.HOST_ENDIAN, Endianness.BIG_ENDIAN));
Expect.equals(expected_value_be, value);
}
@@ -83,10 +83,10 @@
value = bd.getUint32(0, Endianness.LITTLE_ENDIAN);
Expect.equals(0xf4f3f2f1, value);
if (host_is_little_endian) {
- Expect.isTrue(Endianness.HOST_ENDIAN === Endianness.LITTLE_ENDIAN);
+ Expect.isTrue(identical(Endianness.HOST_ENDIAN, Endianness.LITTLE_ENDIAN));
Expect.equals(0xf4f3f2f1, value);
} else {
- Expect.isTrue(Endianness.HOST_ENDIAN === Endianness.BIG_ENDIAN);
+ Expect.isTrue(identical(Endianness.HOST_ENDIAN, Endianness.BIG_ENDIAN));
Expect.equals(0xf1f2f3f4, value);
}
@@ -99,11 +99,11 @@
Expect.equals(expected_value_be, value);
value = bd.getInt64(0, Endianness.LITTLE_ENDIAN);
Expect.equals(expected_value_le, value);
- if (Endianness.HOST_ENDIAN === Endianness.LITTLE_ENDIAN) {
- Expect.isTrue(Endianness.HOST_ENDIAN === Endianness.LITTLE_ENDIAN);
+ if (host_is_little_endian) {
+ Expect.isTrue(identical(Endianness.HOST_ENDIAN, Endianness.LITTLE_ENDIAN));
Expect.equals(expected_value_le, value);
} else {
- Expect.isTrue(Endianness.HOST_ENDIAN === Endianness.BIG_ENDIAN);
+ Expect.isTrue(identical(Endianness.HOST_ENDIAN, Endianness.BIG_ENDIAN));
Expect.equals(expected_value_be, value);
}
@@ -114,10 +114,10 @@
value = bd.getUint64(0, Endianness.LITTLE_ENDIAN);
Expect.equals(0xf8f7f6f5f4f3f2f1, value);
if (host_is_little_endian) {
- Expect.isTrue(Endianness.HOST_ENDIAN === Endianness.LITTLE_ENDIAN);
+ Expect.isTrue(identical(Endianness.HOST_ENDIAN, Endianness.LITTLE_ENDIAN));
Expect.equals(0xf8f7f6f5f4f3f2f1, value);
} else {
- Expect.isTrue(Endianness.HOST_ENDIAN === Endianness.BIG_ENDIAN);
+ Expect.isTrue(identical(Endianness.HOST_ENDIAN, Endianness.BIG_ENDIAN));
Expect.equals(0xf1f2f3f4f5f6f7f8, value);
}
@@ -130,10 +130,10 @@
value = bd.getFloat32(0, Endianness.LITTLE_ENDIAN);
Expect.equals(expected_le_value, value);
if (host_is_little_endian) {
- Expect.isTrue(Endianness.HOST_ENDIAN === Endianness.LITTLE_ENDIAN);
+ Expect.isTrue(identical(Endianness.HOST_ENDIAN, Endianness.LITTLE_ENDIAN));
Expect.equals(expected_le_value, value);
} else {
- Expect.isTrue(Endianness.HOST_ENDIAN === Endianness.BIG_ENDIAN);
+ Expect.isTrue(identical(Endianness.HOST_ENDIAN, Endianness.BIG_ENDIAN));
Expect.equals(expected_be_value, value);
}
@@ -147,10 +147,10 @@
value = bd.getFloat64(0, Endianness.LITTLE_ENDIAN);
Expect.equals(expected_le_value, value);
if (host_is_little_endian) {
- Expect.isTrue(Endianness.HOST_ENDIAN === Endianness.LITTLE_ENDIAN);
+ Expect.isTrue(identical(Endianness.HOST_ENDIAN, Endianness.LITTLE_ENDIAN));
Expect.equals(expected_le_value, value);
} else {
- Expect.isTrue(Endianness.HOST_ENDIAN === Endianness.BIG_ENDIAN);
+ Expect.isTrue(identical(Endianness.HOST_ENDIAN, Endianness.BIG_ENDIAN));
Expect.equals(expected_be_value, value);
}
}
@@ -227,10 +227,10 @@
validate16le(list);
bd.setInt16(0, 0xf1f2, Endianness.HOST_ENDIAN);
if (host_is_little_endian) {
- Expect.isTrue(Endianness.HOST_ENDIAN === Endianness.LITTLE_ENDIAN);
+ Expect.isTrue(identical(Endianness.HOST_ENDIAN, Endianness.LITTLE_ENDIAN));
validate16le(list);
} else {
- Expect.isTrue(Endianness.HOST_ENDIAN === Endianness.BIG_ENDIAN);
+ Expect.isTrue(identical(Endianness.HOST_ENDIAN, Endianness.BIG_ENDIAN));
validate16be(list);
}
@@ -242,10 +242,10 @@
validate16le(list);
bd.setUint16(0, 0xf1f2, Endianness.HOST_ENDIAN);
if (host_is_little_endian) {
- Expect.isTrue(Endianness.HOST_ENDIAN === Endianness.LITTLE_ENDIAN);
+ Expect.isTrue(identical(Endianness.HOST_ENDIAN, Endianness.LITTLE_ENDIAN));
validate16le(list);
} else {
- Expect.isTrue(Endianness.HOST_ENDIAN === Endianness.BIG_ENDIAN);
+ Expect.isTrue(identical(Endianness.HOST_ENDIAN, Endianness.BIG_ENDIAN));
validate16be(list);
}
@@ -257,10 +257,10 @@
validate32le(list);
bd.setInt32(0, 0xf1f2f3f4, Endianness.HOST_ENDIAN);
if (host_is_little_endian) {
- Expect.isTrue(Endianness.HOST_ENDIAN === Endianness.LITTLE_ENDIAN);
+ Expect.isTrue(identical(Endianness.HOST_ENDIAN, Endianness.LITTLE_ENDIAN));
validate32le(list);
} else {
- Expect.isTrue(Endianness.HOST_ENDIAN === Endianness.BIG_ENDIAN);
+ Expect.isTrue(identical(Endianness.HOST_ENDIAN, Endianness.BIG_ENDIAN));
validate32be(list);
}
@@ -272,10 +272,10 @@
validate32le(list);
bd.setUint32(0, 0xf1f2f3f4, Endianness.HOST_ENDIAN);
if (host_is_little_endian) {
- Expect.isTrue(Endianness.HOST_ENDIAN === Endianness.LITTLE_ENDIAN);
+ Expect.isTrue(identical(Endianness.HOST_ENDIAN, Endianness.LITTLE_ENDIAN));
validate32le(list);
} else {
- Expect.isTrue(Endianness.HOST_ENDIAN === Endianness.BIG_ENDIAN);
+ Expect.isTrue(identical(Endianness.HOST_ENDIAN, Endianness.BIG_ENDIAN));
validate32be(list);
}
@@ -287,10 +287,10 @@
validate64le(list);
bd.setInt64(0, 0xf1f2f3f4f5f6f7f8, Endianness.HOST_ENDIAN);
if (host_is_little_endian) {
- Expect.isTrue(Endianness.HOST_ENDIAN === Endianness.LITTLE_ENDIAN);
+ Expect.isTrue(identical(Endianness.HOST_ENDIAN, Endianness.LITTLE_ENDIAN));
validate64le(list);
} else {
- Expect.isTrue(Endianness.HOST_ENDIAN === Endianness.BIG_ENDIAN);
+ Expect.isTrue(identical(Endianness.HOST_ENDIAN, Endianness.BIG_ENDIAN));
validate64be(list);
}
@@ -302,10 +302,10 @@
validate64le(list);
bd.setUint64(0, 0xf1f2f3f4f5f6f7f8, Endianness.HOST_ENDIAN);
if (host_is_little_endian) {
- Expect.isTrue(Endianness.HOST_ENDIAN === Endianness.LITTLE_ENDIAN);
+ Expect.isTrue(identical(Endianness.HOST_ENDIAN, Endianness.LITTLE_ENDIAN));
validate64le(list);
} else {
- Expect.isTrue(Endianness.HOST_ENDIAN === Endianness.BIG_ENDIAN);
+ Expect.isTrue(identical(Endianness.HOST_ENDIAN, Endianness.BIG_ENDIAN));
validate64be(list);
}
@@ -317,10 +317,10 @@
validate32le(list);
bd.setFloat32(0, -2.4060893954673178e+30, Endianness.HOST_ENDIAN);
if (host_is_little_endian) {
- Expect.isTrue(Endianness.HOST_ENDIAN === Endianness.LITTLE_ENDIAN);
+ Expect.isTrue(identical(Endianness.HOST_ENDIAN, Endianness.LITTLE_ENDIAN));
validate32le(list);
} else {
- Expect.isTrue(Endianness.HOST_ENDIAN === Endianness.BIG_ENDIAN);
+ Expect.isTrue(identical(Endianness.HOST_ENDIAN, Endianness.BIG_ENDIAN));
validate32be(list);
}
@@ -332,10 +332,10 @@
validate64le(list);
bd.setFloat64(0, -7.898661740976602e+240, Endianness.HOST_ENDIAN);
if (host_is_little_endian) {
- Expect.isTrue(Endianness.HOST_ENDIAN === Endianness.LITTLE_ENDIAN);
+ Expect.isTrue(identical(Endianness.HOST_ENDIAN, Endianness.LITTLE_ENDIAN));
validate64le(list);
} else {
- Expect.isTrue(Endianness.HOST_ENDIAN === Endianness.BIG_ENDIAN);
+ Expect.isTrue(identical(Endianness.HOST_ENDIAN, Endianness.BIG_ENDIAN));
validate64be(list);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698