Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Issue 1434663004: Aura on Android: Stub Implementation of NativeProcessLauncher. (Closed)

Created:
5 years, 1 month ago by Hadi
Modified:
5 years, 1 month ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@compile_extensions_browser
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Aura on Android: Stub Implementation of NativeProcessLauncher. BUG=548797 Committed: https://crrev.com/78970cdf045848d0abee55557488423d3a10759b Cr-Commit-Position: refs/heads/master@{#360457}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed feedback from patch set 1. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -0 lines) Patch
M chrome/browser/extensions/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
A chrome/browser/extensions/api/messaging/native_process_launcher_android.cc View 1 1 chunk +26 lines, -0 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 18 (6 generated)
Hadi
PTAL. The comment on native_process_launcher_android.cc at https://codereview.chromium.org/1415733008/ suggested creating a stub for NativeProcessLauncer for Android ...
5 years, 1 month ago (2015-11-10 20:51:59 UTC) #2
no sievers
lgtm https://codereview.chromium.org/1434663004/diff/1/chrome/browser/extensions/api/messaging/native_process_launcher_android.cc File chrome/browser/extensions/api/messaging/native_process_launcher_android.cc (right): https://codereview.chromium.org/1434663004/diff/1/chrome/browser/extensions/api/messaging/native_process_launcher_android.cc#newcode1 chrome/browser/extensions/api/messaging/native_process_launcher_android.cc:1: // Copyright (c) 2015 The Chromium Authors. All ...
5 years, 1 month ago (2015-11-10 20:55:00 UTC) #5
mfomitchev
LGTM
5 years, 1 month ago (2015-11-10 20:59:57 UTC) #6
Hadi
https://codereview.chromium.org/1434663004/diff/1/chrome/browser/extensions/api/messaging/native_process_launcher_android.cc File chrome/browser/extensions/api/messaging/native_process_launcher_android.cc (right): https://codereview.chromium.org/1434663004/diff/1/chrome/browser/extensions/api/messaging/native_process_launcher_android.cc#newcode1 chrome/browser/extensions/api/messaging/native_process_launcher_android.cc:1: // Copyright (c) 2015 The Chromium Authors. All rights ...
5 years, 1 month ago (2015-11-10 21:01:23 UTC) #7
Hadi
asargent@ can you please provide OWNERS review for this?
5 years, 1 month ago (2015-11-10 21:01:57 UTC) #8
Hadi
asargent@: friendly ping :)
5 years, 1 month ago (2015-11-16 22:02:24 UTC) #9
asargent_no_longer_on_chrome
[apologies for delay, still digging out from under backlog after a week of vacation] lgtm
5 years, 1 month ago (2015-11-18 17:24:44 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1434663004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1434663004/20001
5 years, 1 month ago (2015-11-18 21:57:36 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/80706)
5 years, 1 month ago (2015-11-18 23:06:32 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1434663004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1434663004/20001
5 years, 1 month ago (2015-11-18 23:16:52 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-19 00:59:12 UTC) #17
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 01:00:02 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/78970cdf045848d0abee55557488423d3a10759b
Cr-Commit-Position: refs/heads/master@{#360457}

Powered by Google App Engine
This is Rietveld 408576698