Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 143463012: Pass rendering state on swapping in a prerendered page. (Closed)

Created:
6 years, 11 months ago by Shuhei Takahashi (google)
Modified:
6 years, 10 months ago
CC:
chromium-reviews, davidben+watch_chromium.org, cbentzel+watch_chromium.org, creis+watch_chromium.org, marja+watch_chromium.org, tburkard+watch_chromium.org, Avi (use Gerrit), gavinp+prer_chromium.org, dominich+watch_chromium.org, ajwong+watch_chromium.org, msw
Base URL:
https://chromium.googlesource.com/chromium/src.git@dev
Visibility:
Public.

Description

Pass rendering state on swapping in a prerendered page. Android Chrome needs to learn whether or not WebContentsObserver::DidFinishLoad() has been called on the prerendered WebContents during the call to CoreTabHelperDelegate::SwapTabContents() here: https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/prerender/prerender_manager.cc&l=634&q=prerendermanager&type=cs&sq=package:chromium BUG=335479 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247902

Patch Set 1 #

Patch Set 2 : . #

Total comments: 4

Patch Set 3 : Introduced didStartLoad #

Patch Set 4 : sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -13 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/EmptyTabObserver.java View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/TabBase.java View 1 2 3 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/TabObserver.java View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/android/tab_android.h View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/android/tab_android.cc View 1 2 3 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/prerender/prerender_manager.cc View 1 2 3 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/sessions/session_restore_android.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser.h View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/ui/browser.cc View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/ui/tab_contents/core_tab_helper_delegate.h View 1 2 1 chunk +5 lines, -1 line 0 comments Download
M chrome/browser/ui/tab_contents/core_tab_helper_delegate.cc View 1 2 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Shuhei Takahashi (google)
tedchoc@chromium.org, mmenke@chromium.org: Please review the whole change. msw@chromium.org: Please review changes in chrome/browser/ui/...
6 years, 11 months ago (2014-01-28 05:26:11 UTC) #1
mmenke
On 2014/01/28 05:26:11, nya wrote: > mailto:tedchoc@chromium.org, mmenke@chromium.org: Please review the whole change. > > ...
6 years, 10 months ago (2014-01-28 16:58:17 UTC) #2
Ted C
Just the question about restored tabs https://codereview.chromium.org/143463012/diff/30001/chrome/android/java/src/org/chromium/chrome/browser/TabBase.java File chrome/android/java/src/org/chromium/chrome/browser/TabBase.java (right): https://codereview.chromium.org/143463012/diff/30001/chrome/android/java/src/org/chromium/chrome/browser/TabBase.java#newcode844 chrome/android/java/src/org/chromium/chrome/browser/TabBase.java:844: observer.onWebContentsSwapped(this, didFinishLoad); in ...
6 years, 10 months ago (2014-01-28 18:11:43 UTC) #3
msw
On 2014/01/28 05:26:11, nya wrote: > msw@chromium.org: Please review changes in chrome/browser/ui/... I'd like to ...
6 years, 10 months ago (2014-01-28 22:52:04 UTC) #4
Shuhei Takahashi (google)
ben@chromium.org: Please review changes in chrome/browser/ui/... I'll address other reviewers' comments in a few hours. ...
6 years, 10 months ago (2014-01-29 00:18:15 UTC) #5
Ben Goodger (Google)
browser/ui lgtm
6 years, 10 months ago (2014-01-29 00:34:18 UTC) #6
Shuhei Takahashi (google)
https://codereview.chromium.org/143463012/diff/30001/chrome/android/java/src/org/chromium/chrome/browser/TabBase.java File chrome/android/java/src/org/chromium/chrome/browser/TabBase.java (right): https://codereview.chromium.org/143463012/diff/30001/chrome/android/java/src/org/chromium/chrome/browser/TabBase.java#newcode844 chrome/android/java/src/org/chromium/chrome/browser/TabBase.java:844: observer.onWebContentsSwapped(this, didFinishLoad); On 2014/01/28 18:11:44, Ted C wrote: > ...
6 years, 10 months ago (2014-01-29 05:58:09 UTC) #7
Ted C
android: lgtm
6 years, 10 months ago (2014-01-29 21:25:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nya@google.com/143463012/70001
6 years, 10 months ago (2014-01-30 04:15:05 UTC) #9
commit-bot: I haz the power
6 years, 10 months ago (2014-01-30 08:47:44 UTC) #10
Message was sent while issue was closed. 
Change committed as 247902

Powered by Google App Engine
This is Rietveld 408576698