Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Side by Side Diff: chrome/browser/ui/tests/elide_url_unittest.cc

Issue 143463006: Remove net dependency from ui/gfx (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: add gurl include to elide_url_unittest.cc Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
(Empty)
1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "chrome/browser/ui/elide_url.h"
6
7 #include "base/strings/utf_string_conversions.h"
8 #include "testing/gtest/include/gtest/gtest.h"
9 #include "ui/gfx/font_list.h"
10 #include "ui/gfx/text_elider.h"
11 #include "ui/gfx/text_utils.h"
12 #include "url/gurl.h"
13
14 using base::UTF8ToUTF16;
15 using gfx::GetStringWidthF;
16 using gfx::kEllipsis;
17
18 namespace {
19
20 struct Testcase {
21 const std::string input;
22 const std::string output;
23 };
24
25 void RunUrlTest(Testcase* testcases, size_t num_testcases) {
26 static const gfx::FontList font_list;
27 for (size_t i = 0; i < num_testcases; ++i) {
28 const GURL url(testcases[i].input);
29 // Should we test with non-empty language list?
30 // That's kinda redundant with net_util_unittests.
31 const float available_width =
32 GetStringWidthF(UTF8ToUTF16(testcases[i].output), font_list);
33 EXPECT_EQ(UTF8ToUTF16(testcases[i].output),
34 ElideUrl(url, font_list, available_width, std::string()));
35 }
36 }
37
38 // Test eliding of commonplace URLs.
39 TEST(TextEliderTest, TestGeneralEliding) {
40 const std::string kEllipsisStr(kEllipsis);
41 Testcase testcases[] = {
42 {"http://www.google.com/intl/en/ads/",
43 "www.google.com/intl/en/ads/"},
44 {"http://www.google.com/intl/en/ads/", "www.google.com/intl/en/ads/"},
45 {"http://www.google.com/intl/en/ads/",
46 "google.com/intl/" + kEllipsisStr + "/ads/"},
47 {"http://www.google.com/intl/en/ads/",
48 "google.com/" + kEllipsisStr + "/ads/"},
49 {"http://www.google.com/intl/en/ads/", "google.com/" + kEllipsisStr},
50 {"http://www.google.com/intl/en/ads/", "goog" + kEllipsisStr},
51 {"https://subdomain.foo.com/bar/filename.html",
52 "subdomain.foo.com/bar/filename.html"},
53 {"https://subdomain.foo.com/bar/filename.html",
54 "subdomain.foo.com/" + kEllipsisStr + "/filename.html"},
55 {"http://subdomain.foo.com/bar/filename.html",
56 kEllipsisStr + "foo.com/" + kEllipsisStr + "/filename.html"},
57 {"http://www.google.com/intl/en/ads/?aLongQueryWhichIsNotRequired",
58 "www.google.com/intl/en/ads/?aLongQ" + kEllipsisStr},
59 };
60
61 RunUrlTest(testcases, arraysize(testcases));
62 }
63
64 // When there is very little space available, the elision code will shorten
65 // both path AND file name to an ellipsis - ".../...". To avoid this result,
66 // there is a hack in place that simply treats them as one string in this
67 // case.
68 TEST(TextEliderTest, TestTrailingEllipsisSlashEllipsisHack) {
69 const std::string kEllipsisStr(kEllipsis);
70
71 // Very little space, would cause double ellipsis.
72 gfx::FontList font_list;
73 GURL url("http://battersbox.com/directory/foo/peter_paul_and_mary.html");
74 float available_width = GetStringWidthF(
75 UTF8ToUTF16("battersbox.com/" + kEllipsisStr + "/" + kEllipsisStr),
76 font_list);
77
78 // Create the expected string, after elision. Depending on font size, the
79 // directory might become /dir... or /di... or/d... - it never should be
80 // shorter than that. (If it is, the font considers d... to be longer
81 // than .../... - that should never happen).
82 ASSERT_GT(GetStringWidthF(UTF8ToUTF16(kEllipsisStr + "/" + kEllipsisStr),
83 font_list),
84 GetStringWidthF(UTF8ToUTF16("d" + kEllipsisStr), font_list));
85 GURL long_url("http://battersbox.com/directorynameisreallylongtoforcetrunc");
86 base::string16 expected =
87 ElideUrl(long_url, font_list, available_width, std::string());
88 // Ensure that the expected result still contains part of the directory name.
89 ASSERT_GT(expected.length(), std::string("battersbox.com/d").length());
90 EXPECT_EQ(expected,
91 ElideUrl(url, font_list, available_width, std::string()));
92
93 // More space available - elide directories, partially elide filename.
94 Testcase testcases[] = {
95 {"http://battersbox.com/directory/foo/peter_paul_and_mary.html",
96 "battersbox.com/" + kEllipsisStr + "/peter" + kEllipsisStr},
97 };
98 RunUrlTest(testcases, arraysize(testcases));
99 }
100
101 // Test eliding of empty strings, URLs with ports, passwords, queries, etc.
102 TEST(TextEliderTest, TestMoreEliding) {
103 const std::string kEllipsisStr(kEllipsis);
104 Testcase testcases[] = {
105 {"http://www.google.com/foo?bar", "www.google.com/foo?bar"},
106 {"http://xyz.google.com/foo?bar", "xyz.google.com/foo?" + kEllipsisStr},
107 {"http://xyz.google.com/foo?bar", "xyz.google.com/foo" + kEllipsisStr},
108 {"http://xyz.google.com/foo?bar", "xyz.google.com/fo" + kEllipsisStr},
109 {"http://a.b.com/pathname/c?d", "a.b.com/" + kEllipsisStr + "/c?d"},
110 {"", ""},
111 {"http://foo.bar..example.com...hello/test/filename.html",
112 "foo.bar..example.com...hello/" + kEllipsisStr + "/filename.html"},
113 {"http://foo.bar../", "foo.bar.."},
114 {"http://xn--1lq90i.cn/foo", "\xe5\x8c\x97\xe4\xba\xac.cn/foo"},
115 {"http://me:mypass@secrethost.com:99/foo?bar#baz",
116 "secrethost.com:99/foo?bar#baz"},
117 {"http://me:mypass@ss%xxfdsf.com/foo", "ss%25xxfdsf.com/foo"},
118 {"mailto:elgoato@elgoato.com", "mailto:elgoato@elgoato.com"},
119 {"javascript:click(0)", "javascript:click(0)"},
120 {"https://chess.eecs.berkeley.edu:4430/login/arbitfilename",
121 "chess.eecs.berkeley.edu:4430/login/arbitfilename"},
122 {"https://chess.eecs.berkeley.edu:4430/login/arbitfilename",
123 kEllipsisStr + "berkeley.edu:4430/" + kEllipsisStr + "/arbitfilename"},
124
125 // Unescaping.
126 {"http://www/%E4%BD%A0%E5%A5%BD?q=%E4%BD%A0%E5%A5%BD#\xe4\xbd\xa0",
127 "www/\xe4\xbd\xa0\xe5\xa5\xbd?q=\xe4\xbd\xa0\xe5\xa5\xbd#\xe4\xbd\xa0"},
128
129 // Invalid unescaping for path. The ref will always be valid UTF-8. We don't
130 // bother to do too many edge cases, since these are handled by the escaper
131 // unittest.
132 {"http://www/%E4%A0%E5%A5%BD?q=%E4%BD%A0%E5%A5%BD#\xe4\xbd\xa0",
133 "www/%E4%A0%E5%A5%BD?q=\xe4\xbd\xa0\xe5\xa5\xbd#\xe4\xbd\xa0"},
134 };
135
136 RunUrlTest(testcases, arraysize(testcases));
137 }
138
139 // Test eliding of file: URLs.
140 TEST(TextEliderTest, TestFileURLEliding) {
141 const std::string kEllipsisStr(kEllipsis);
142 Testcase testcases[] = {
143 {"file:///C:/path1/path2/path3/filename",
144 "file:///C:/path1/path2/path3/filename"},
145 {"file:///C:/path1/path2/path3/filename",
146 "C:/path1/path2/path3/filename"},
147 // GURL parses "file:///C:path" differently on windows than it does on posix.
148 #if defined(OS_WIN)
149 {"file:///C:path1/path2/path3/filename",
150 "C:/path1/path2/" + kEllipsisStr + "/filename"},
151 {"file:///C:path1/path2/path3/filename",
152 "C:/path1/" + kEllipsisStr + "/filename"},
153 {"file:///C:path1/path2/path3/filename",
154 "C:/" + kEllipsisStr + "/filename"},
155 #endif
156 {"file://filer/foo/bar/file", "filer/foo/bar/file"},
157 {"file://filer/foo/bar/file", "filer/foo/" + kEllipsisStr + "/file"},
158 {"file://filer/foo/bar/file", "filer/" + kEllipsisStr + "/file"},
159 };
160
161 RunUrlTest(testcases, arraysize(testcases));
162 }
163
164 } // namespace
OLDNEW
« no previous file with comments | « chrome/browser/ui/gtk/status_bubble_gtk.cc ('k') | chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698