third_party/WebKit/LayoutTests/http/tests/inspector/elements-test.js - Issue 1434613002: DevTools: kill WebInspector.StylesSectionModel class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/elements-test.js

Issue 1434613002: DevTools: kill WebInspector.StylesSectionModel class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/LayoutTests/http/tests/inspector/elements-test.js

diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/elements-test.js b/third_party/WebKit/LayoutTests/http/tests/inspector/elements-test.js

index b173fd247a04e1d35d341da8d99b880eee1d2210..ba2b2f186259415516b0dc7beaa1107cba9a1487 100644

--- a/third_party/WebKit/LayoutTests/http/tests/inspector/elements-test.js

+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/elements-test.js

@@ -355,7 +355,7 @@ InspectorTest.dumpSelectedElementStyles = function(excludeComputed, excludeMatch

InspectorTest.dumpComputedStyle();

for (var block of sectionBlocks) {

for (var section of block.sections) {

- if (section.rule() && excludeMatched)

+ if (section.style().parentRule && excludeMatched)

continue;

if (section.element.previousSibling && section.element.previousSibling.className === "sidebar-separator") {

var nodeDescription = "";

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/inspector/elements/styles-1/add-new-rule-inline-style-csp.html » ('j') | no next file with comments »