Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1805)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: samples/samples.gyp

Issue 1434543003: Merge to XFA: Fix all relative includes to third_party. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa
Patch Set: fix merge, attempt 1 Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« samples/BUILD.gn ('K') | « samples/pdfium_test.cc ('k') | testing/embedder_test.h » ('j') | third_party/BUILD.gn » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: samples/samples.gyp
diff --git a/samples/samples.gyp b/samples/samples.gyp
index 0044c5c030ab51c996ba32ff4ac2a8c1a59d70ab..35d2e50f243c7a51c56ef3a204b22ee880efb474 100644
--- a/samples/samples.gyp
+++ b/samples/samples.gyp
@@ -19,6 +19,11 @@
'PNGPREFIX_H',
'PNG_USE_READ_MACROS',
],
+ 'include_dirs': [
+ # This is implicit in GN.
+ '<(DEPTH)',
+ '..',
+ ],
'conditions': [
['pdf_enable_v8==1', {
'defines': [
@@ -59,9 +64,6 @@
'../pdfium.gyp:fxcodec',
'../third_party/third_party.gyp:pdfium_base',
],
- 'include_dirs': [
- '../../',
- ],
'sources': [
'image_diff.cc',
'image_diff_png.h',
« samples/BUILD.gn ('K') | « samples/pdfium_test.cc ('k') | testing/embedder_test.h » ('j') | third_party/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698