Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Issue 1434533004: include what you use: errno.h and string.h in base/ (Closed)

Created:
5 years, 1 month ago by Mostyn Bramley-Moore
Modified:
5 years, 1 month ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, gavinp+memory_chromium.org, jshin+watch_chromium.org, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

include what you use: errno.h and string.h in base/ Adding some missing errno.h includes for errno and string.h for strerror in base/ Committed: https://crrev.com/522dfa59c94b0b49d0decee4af01f35730110bf1 Cr-Commit-Position: refs/heads/master@{#358477}

Patch Set 1 #

Total comments: 2

Patch Set 2 : insert blank line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M base/memory/shared_memory_mac.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/memory/shared_memory_posix.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/process/kill_mac.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/process/kill_posix.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/process/process_iterator_freebsd.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/process/process_posix.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/strings/safe_sprintf.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Mostyn Bramley-Moore
@thestig: here's a small include-what-you-use fix.
5 years, 1 month ago (2015-11-06 23:09:23 UTC) #2
Lei Zhang
lgtm https://codereview.chromium.org/1434533004/diff/1/base/strings/safe_sprintf.cc File base/strings/safe_sprintf.cc (right): https://codereview.chromium.org/1434533004/diff/1/base/strings/safe_sprintf.cc#newcode8 base/strings/safe_sprintf.cc:8: #include <string.h> Same here as the chrome/ CL ...
5 years, 1 month ago (2015-11-06 23:31:56 UTC) #3
Mostyn Bramley-Moore
Thanks. https://codereview.chromium.org/1434533004/diff/1/base/strings/safe_sprintf.cc File base/strings/safe_sprintf.cc (right): https://codereview.chromium.org/1434533004/diff/1/base/strings/safe_sprintf.cc#newcode8 base/strings/safe_sprintf.cc:8: #include <string.h> On 2015/11/06 23:31:56, Lei Zhang wrote: ...
5 years, 1 month ago (2015-11-06 23:36:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1434533004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1434533004/20001
5 years, 1 month ago (2015-11-06 23:37:16 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-07 00:57:21 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-07 00:58:18 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/522dfa59c94b0b49d0decee4af01f35730110bf1
Cr-Commit-Position: refs/heads/master@{#358477}

Powered by Google App Engine
This is Rietveld 408576698