Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 1434533002: Add a few items to ContextMenu. (Closed)

Created:
5 years, 1 month ago by aurimas (slooooooooow)
Modified:
5 years, 1 month ago
Reviewers:
Ted C
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a few items to ContextMenu. This CL adds contextmenu_save_link_as to fullscreen tabs mode and contextmenu_search_by_image to custom tabs mode of context menu. BUG=550272 Committed: https://crrev.com/12aa65007fe22d29520d8858291e3bedff9c9887 Cr-Commit-Position: refs/heads/master@{#358095}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java View 4 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1434533002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1434533002/1
5 years, 1 month ago (2015-11-05 17:27:03 UTC) #2
aurimas (slooooooooow)
PTAL. Adjusting the context menus to rolfe's suggestions. See crbug.com/550272
5 years, 1 month ago (2015-11-05 17:27:29 UTC) #4
Ted C
lgtm
5 years, 1 month ago (2015-11-05 17:28:30 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-05 18:08:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1434533002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1434533002/1
5 years, 1 month ago (2015-11-05 18:33:46 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-05 18:46:29 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-11-05 18:47:20 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/12aa65007fe22d29520d8858291e3bedff9c9887
Cr-Commit-Position: refs/heads/master@{#358095}

Powered by Google App Engine
This is Rietveld 408576698