Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Side by Side Diff: Source/core/dom/ClassCollection.h

Issue 143453010: Have getElementsByClassName() / getElementsByTagName*() return an HTMLCollection (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Null HTMLCollection handling Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007 Apple Inc. All rights reserved. 2 * Copyright (C) 2007 Apple Inc. All rights reserved.
3 * Copyright (C) 2007 David Smith (catfish.man@gmail.com) 3 * Copyright (C) 2007 David Smith (catfish.man@gmail.com)
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 8 *
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
11 * 2. Redistributions in binary form must reproduce the above copyright 11 * 2. Redistributions in binary form must reproduce the above copyright
12 * notice, this list of conditions and the following disclaimer in the 12 * notice, this list of conditions and the following disclaimer in the
13 * documentation and/or other materials provided with the distribution. 13 * documentation and/or other materials provided with the distribution.
14 * 3. Neither the name of Apple Computer, Inc. ("Apple") nor the names of 14 * 3. Neither the name of Apple Computer, Inc. ("Apple") nor the names of
15 * its contributors may be used to endorse or promote products derived 15 * its contributors may be used to endorse or promote products derived
16 * from this software without specific prior written permission. 16 * from this software without specific prior written permission.
17 * 17 *
18 * THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS "AS IS" AND ANY 18 * THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS "AS IS" AND ANY
19 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED 19 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
20 * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE 20 * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
21 * DISCLAIMED. IN NO EVENT SHALL APPLE OR ITS CONTRIBUTORS BE LIABLE FOR ANY 21 * DISCLAIMED. IN NO EVENT SHALL APPLE OR ITS CONTRIBUTORS BE LIABLE FOR ANY
22 * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES 22 * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
23 * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; 23 * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
24 * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND 24 * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
25 * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 25 * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
26 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF 26 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
27 * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 27 * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
28 */ 28 */
29 29
30 #ifndef ClassNodeList_h 30 #ifndef ClassCollection_h
31 #define ClassNodeList_h 31 #define ClassCollection_h
32 32
33 #include "core/dom/Element.h" 33 #include "core/dom/Element.h"
34 #include "core/dom/LiveNodeList.h"
35 #include "core/dom/Node.h"
36 #include "core/dom/SpaceSplitString.h" 34 #include "core/dom/SpaceSplitString.h"
35 #include "core/html/HTMLCollection.h"
37 36
38 namespace WebCore { 37 namespace WebCore {
39 38
40 class ClassNodeList FINAL : public LiveNodeList { 39 class ClassCollection FINAL : public HTMLCollection {
41 public: 40 public:
42 // classNames argument is an AtomicString because it is common for Elements to share the same class names. 41 // classNames argument is an AtomicString because it is common for Elements to share the same class names.
43 // It is also used to construct a SpaceSplitString (m_classNames) and its co nstructor requires an AtomicString. 42 // It is also used to construct a SpaceSplitString (m_classNames) and its co nstructor requires an AtomicString.
44 static PassRefPtr<ClassNodeList> create(PassRefPtr<ContainerNode> rootNode, CollectionType type, const AtomicString& classNames) 43 static PassRefPtr<ClassCollection> create(ContainerNode* rootNode, Collectio nType type, const AtomicString& classNames)
45 { 44 {
46 ASSERT_UNUSED(type, type == ClassNodeListType); 45 ASSERT_UNUSED(type, type == ClassCollectionType);
47 return adoptRef(new ClassNodeList(rootNode, classNames)); 46 return adoptRef(new ClassCollection(rootNode, classNames));
48 } 47 }
49 48
50 virtual ~ClassNodeList(); 49 virtual ~ClassCollection();
51 50
52 bool nodeMatchesInlined(const Element&) const; 51 bool elementMatches(const Element&) const;
53 52
54 private: 53 private:
55 ClassNodeList(PassRefPtr<ContainerNode> rootNode, const AtomicString& classN ames); 54 ClassCollection(ContainerNode* rootNode, const AtomicString& classNames);
56
57 virtual bool nodeMatches(const Element&) const OVERRIDE;
58 55
59 SpaceSplitString m_classNames; 56 SpaceSplitString m_classNames;
60 AtomicString m_originalClassNames; 57 AtomicString m_originalClassNames;
61 }; 58 };
62 59
63 inline bool ClassNodeList::nodeMatchesInlined(const Element& testNode) const 60 inline bool ClassCollection::elementMatches(const Element& testElement) const
64 { 61 {
65 if (!testNode.hasClass()) 62 if (!testElement.hasClass())
66 return false; 63 return false;
67 if (!m_classNames.size()) 64 if (!m_classNames.size())
68 return false; 65 return false;
69 // FIXME: DOM4 allows getElementsByClassName to return non StyledElement. 66 // FIXME: DOM4 allows getElementsByClassName to return non StyledElement.
70 // https://bugs.webkit.org/show_bug.cgi?id=94718 67 // https://bugs.webkit.org/show_bug.cgi?id=94718
71 if (!testNode.isStyledElement()) 68 if (!testElement.isStyledElement())
72 return false; 69 return false;
73 return testNode.classNames().containsAll(m_classNames); 70 return testElement.classNames().containsAll(m_classNames);
74 } 71 }
75 72
76 } // namespace WebCore 73 } // namespace WebCore
77 74
78 #endif // ClassNodeList_h 75 #endif // ClassCollection_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698