Have getElementsByClassName() / getElementsByTagName*() return an HTMLCollection

LayoutTests/fast/js/getOwnPropertyDescriptor-expected.txt

 Test to ensure correct behaviour of Object.getOwnPropertyDescriptor
 
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 
 PASS Object.getOwnPropertyDescriptor({}, 'undefinedProperty') is undefined.
 PASS Object.getOwnPropertyDescriptor({definedProperty:'defined'}, 'definedProperty').value is "defined"
 PASS Object.getOwnPropertyDescriptor({definedProperty:'defined'}, 'definedProperty').hasOwnProperty('get') is false
 PASS Object.getOwnPropertyDescriptor({definedProperty:'defined'}, 'definedProperty').hasOwnProperty('set') is false
 PASS Object.getOwnPropertyDescriptor({definedProperty:'defined'}, 'definedProperty').enumerable is true
@@ skipping 124 matching lines @@
 PASS Object.getOwnPropertyDescriptor(global, 'length').enumerable is true
 FAIL Object.getOwnPropertyDescriptor(global, 'length').configurable should be false. Was true.
 FAIL Object.getOwnPropertyDescriptor(global, 0).value should be [object Window]. Threw exception TypeError: Cannot read property 'value' of undefined
 FAIL Object.getOwnPropertyDescriptor(global, 0).hasOwnProperty('get') should be false. Threw exception TypeError: Cannot call method 'hasOwnProperty' of undefined
 FAIL Object.getOwnPropertyDescriptor(global, 0).hasOwnProperty('set') should be false. Threw exception TypeError: Cannot call method 'hasOwnProperty' of undefined
 FAIL Object.getOwnPropertyDescriptor(global, 0).enumerable should be false. Threw exception TypeError: Cannot read property 'enumerable' of undefined
 FAIL Object.getOwnPropertyDescriptor(global, 0).configurable should be false. Threw exception TypeError: Cannot read property 'configurable' of undefined
 PASS Object.getOwnPropertyDescriptor(document.getElementsByTagName('div'), 'length').value is 1
 PASS Object.getOwnPropertyDescriptor(document.getElementsByTagName('div'), 'length').hasOwnProperty('get') is false
 PASS Object.getOwnPropertyDescriptor(document.getElementsByTagName('div'), 'length').hasOwnProperty('set') is false
-FAIL Object.getOwnPropertyDescriptor(document.getElementsByTagName('div'), 'length').enumerable should be true. Was false.
+PASS Object.getOwnPropertyDescriptor(document.getElementsByTagName('div'), 'length').enumerable is true

[arv (Not doing code reviews), 2014/01/29 04:45:48]

length should not be enumerable.

[Inactive, 2014/01/29 14:08:14]

I see, is this documented somewhere?
http://dom.spec.whatwg.org/#dom-htmlcollection-length does not seem to mention
this.

I am trying to figure out why NodeList.length is not enumerable but
HTMLCollection.length seems to be. The IDL seems the same.

[Inactive, 2014/01/29 16:21:34]

Done. I confirmed that FF26 and IE11 also mark HTMLCollection.length as
NotEnumerable. This is not strictly related to this patch but anyway.

[Inactive, 2014/01/29 21:17:36]

Not strictly related to this CL so I filed
https://code.google.com/p/chromium/issues/detail?id=339202 for it.

 FAIL Object.getOwnPropertyDescriptor(document.getElementsByTagName('div'), 'length').configurable should be false. Was true.
 PASS Object.getOwnPropertyDescriptor(document.getElementsByTagName('div'), 0).value is document.getElementsByTagName('div')[0]
 PASS Object.getOwnPropertyDescriptor(document.getElementsByTagName('div'), 0).hasOwnProperty('get') is false
 PASS Object.getOwnPropertyDescriptor(document.getElementsByTagName('div'), 0).hasOwnProperty('set') is false
 PASS Object.getOwnPropertyDescriptor(document.getElementsByTagName('div'), 0).enumerable is true
 FAIL Object.getOwnPropertyDescriptor(document.getElementsByTagName('div'), 0).configurable should be false. Was true.
 PASS Object.getOwnPropertyDescriptor(document.getElementsByClassName('pass'), 0).value is document.getElementsByClassName('pass')[0]
 PASS Object.getOwnPropertyDescriptor(document.getElementsByClassName('pass'), 0).hasOwnProperty('get') is false
 PASS Object.getOwnPropertyDescriptor(document.getElementsByClassName('pass'), 0).hasOwnProperty('set') is false
 PASS Object.getOwnPropertyDescriptor(document.getElementsByClassName('pass'), 0).enumerable is true
 FAIL Object.getOwnPropertyDescriptor(document.getElementsByClassName('pass'), 0).configurable should be false. Was true.
 PASS Object.getOwnPropertyDescriptor(document.getElementsByClassName('pass'), 'length').value is document.getElementsByClassName('pass').length
 PASS Object.getOwnPropertyDescriptor(document.getElementsByClassName('pass'), 'length').hasOwnProperty('get') is false
 PASS Object.getOwnPropertyDescriptor(document.getElementsByClassName('pass'), 'length').hasOwnProperty('set') is false
-FAIL Object.getOwnPropertyDescriptor(document.getElementsByClassName('pass'), 'length').enumerable should be true. Was false.
+PASS Object.getOwnPropertyDescriptor(document.getElementsByClassName('pass'), 'length').enumerable is true
 FAIL Object.getOwnPropertyDescriptor(document.getElementsByClassName('pass'), 'length').configurable should be false. Was true.
 PASS Object.getOwnPropertyDescriptor(select, 'length').value is select.length
 PASS Object.getOwnPropertyDescriptor(select, 'length').hasOwnProperty('get') is false
 PASS Object.getOwnPropertyDescriptor(select, 'length').hasOwnProperty('set') is false
 PASS Object.getOwnPropertyDescriptor(select, 'length').enumerable is true
 FAIL Object.getOwnPropertyDescriptor(select, 'length').configurable should be false. Was true.
 PASS Object.getOwnPropertyDescriptor(select, 0).value is select[0]
 PASS Object.getOwnPropertyDescriptor(select, 0).hasOwnProperty('get') is false
 PASS Object.getOwnPropertyDescriptor(select, 0).hasOwnProperty('set') is false
 PASS Object.getOwnPropertyDescriptor(select, 0).enumerable is true
@@ skipping 36 matching lines @@
 PASS property is 'enumerable'
 PASS property is 'configurable'
 PASS property is 'get'
 PASS property is 'set'
 PASS property is 'enumerable'
 PASS property is 'configurable'
 PASS successfullyParsed is true
 
 TEST COMPLETE