Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issue 143453008: [Mac] Remove a panel from stack window bounds update list when it is being removed (Closed)

Created:
6 years, 10 months ago by jianli
Modified:
6 years, 10 months ago
Reviewers:
Dmitry Titov
CC:
chromium-reviews
Visibility:
Public.

Description

[Mac] Remove a panel from stack window bounds update list when it is being removed The crash in the bug seems to occur when 2 stacked panels are being removed in a very short peirod of time. When 1st panel is being removed, other stacked panels could be queued for update. If 2nd panel, that is in this update list, is then removed, it should be removed from the update list. This only occurs on Mac. Windows does not have the problem due to the similar logic. Linux GTK does not either due to that the update will be performed immediately. BUG=336582 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247648

Patch Set 1 #

Patch Set 2 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/browser/ui/cocoa/panels/panel_stack_window_cocoa.mm View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jianli
6 years, 10 months ago (2014-01-28 23:01:27 UTC) #1
Dmitry Titov
lgtm after fixing compile issue.
6 years, 10 months ago (2014-01-29 01:12:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jianli@chromium.org/143453008/20001
6 years, 10 months ago (2014-01-29 01:56:02 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) check_deps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=220031
6 years, 10 months ago (2014-01-29 04:39:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jianli@chromium.org/143453008/20001
6 years, 10 months ago (2014-01-29 05:33:17 UTC) #5
commit-bot: I haz the power
6 years, 10 months ago (2014-01-29 06:30:06 UTC) #6
Message was sent while issue was closed.
Change committed as 247648

Powered by Google App Engine
This is Rietveld 408576698