Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 143453003: MIPS: Add missing cctests of DoubleToIStub (r16322). (Closed)

Created:
6 years, 11 months ago by kilvadyb
Modified:
6 years, 11 months ago
CC:
v8-dev
Base URL:
https://github.com/v8/v8.git@gbl
Visibility:
Public.

Description

MIPS: Add missing cctests of DoubleToIStub (r16322). BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -34 lines) Patch
M src/mips/code-stubs-mips.cc View 2 chunks +7 lines, -3 lines 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
A + test/cctest/test-code-stubs-mips.cc View 5 chunks +35 lines, -31 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kilvadyb
6 years, 11 months ago (2014-01-21 20:52:27 UTC) #1
Paul Lind
LGTM, but we need additional review on this one. Benedikt, Jakob, could one of you ...
6 years, 11 months ago (2014-01-21 22:31:24 UTC) #2
Jakob Kummerow
lgtm
6 years, 11 months ago (2014-01-22 08:56:15 UTC) #3
palfia
6 years, 11 months ago (2014-01-22 13:44:29 UTC) #4
Committed as r18751.

Powered by Google App Engine
This is Rietveld 408576698