Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1434523002: [es6] Implement @@match subclassing. (Closed)

Created:
5 years, 1 month ago by Yang
Modified:
5 years ago
Reviewers:
Dan Ehrenberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] Implement @@match subclassing. BUG=v8:4305 LOG=N Committed: https://crrev.com/eeb7c0555853fc9e0a42fd741ebe5478b4be51ad Cr-Commit-Position: refs/heads/master@{#32210}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -9 lines) Patch
M src/js/regexp.js View 1 2 3 chunks +17 lines, -1 line 0 comments Download
M src/js/string.js View 1 2 2 chunks +14 lines, -8 lines 0 comments Download
A test/mjsunit/harmony/string-match.js View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Yang
5 years, 1 month ago (2015-11-17 14:41:38 UTC) #2
Dan Ehrenberg
lgtm Sorry for the delay
5 years, 1 month ago (2015-11-23 19:55:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1434523002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1434523002/40001
5 years ago (2015-11-24 13:30:29 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-11-24 13:57:01 UTC) #7
commit-bot: I haz the power
5 years ago (2015-11-24 13:57:39 UTC) #8
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/eeb7c0555853fc9e0a42fd741ebe5478b4be51ad
Cr-Commit-Position: refs/heads/master@{#32210}

Powered by Google App Engine
This is Rietveld 408576698