Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(881)

Side by Side Diff: build/toolchain/win/BUILD.gn

Issue 1434453006: GN: Fix Windows tool("asm") for x86-64 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 declare_args() { 5 declare_args() {
6 # Path to the directory containing the VC binaries for the right 6 # Path to the directory containing the VC binaries for the right
7 # combination of host and target architectures. Currently only the 7 # combination of host and target architectures. Currently only the
8 # 64-bit host toolchain is supported, with either 32-bit or 64-bit targets. 8 # 64-bit host toolchain is supported, with either 32-bit or 64-bit targets.
9 # If vc_bin_dir is not specified on the command line (and it normally 9 # If vc_bin_dir is not specified on the command line (and it normally
10 # isn't), we will dynamically determine the right value to use at runtime. 10 # isn't), we will dynamically determine the right value to use at runtime.
(...skipping 103 matching lines...) Expand 10 before | Expand all | Expand 10 after
114 114
115 tool("rc") { 115 tool("rc") {
116 command = "$python_path gyp-win-tool rc-wrapper $env rc.exe {{defines}} {{ include_dirs}} /fo{{output}} {{source}}" 116 command = "$python_path gyp-win-tool rc-wrapper $env rc.exe {{defines}} {{ include_dirs}} /fo{{output}} {{source}}"
117 outputs = [ 117 outputs = [
118 "{{target_out_dir}}/{{target_output_name}}/{{source_name_part}}.res", 118 "{{target_out_dir}}/{{target_output_name}}/{{source_name_part}}.res",
119 ] 119 ]
120 description = "RC {{output}}" 120 description = "RC {{output}}"
121 } 121 }
122 122
123 tool("asm") { 123 tool("asm") {
124 command = "$python_path gyp-win-tool asm-wrapper $env ml.exe {{defines}} { {include_dirs}} {{asmflags}} /c /Fo{{output}} {{source}}" 124 if (current_cpu == "x64") {
125 ml = "ml64.exe"
126 } else {
127 ml = "ml.exe"
128 }
129 command = "$python_path gyp-win-tool asm-wrapper $env $ml {{defines}} {{in clude_dirs}} {{asmflags}} /c /Fo{{output}} {{source}}"
125 description = "ASM {{output}}" 130 description = "ASM {{output}}"
126 outputs = [ 131 outputs = [
127 "{{target_out_dir}}/{{target_output_name}}/{{source_name_part}}.obj", 132 "{{target_out_dir}}/{{target_output_name}}/{{source_name_part}}.obj",
128 ] 133 ]
129 } 134 }
130 135
131 tool("alink") { 136 tool("alink") {
132 rspfile = "{{output}}.rsp" 137 rspfile = "{{output}}.rsp"
133 command = "$python_path gyp-win-tool link-wrapper $env False lib.exe /nolo go /ignore:4221 /OUT:{{output}} @$rspfile" 138 command = "$python_path gyp-win-tool link-wrapper $env False lib.exe /nolo go /ignore:4221 /OUT:{{output}} @$rspfile"
134 description = "LIB {{output}}" 139 description = "LIB {{output}}"
(...skipping 155 matching lines...) Expand 10 before | Expand all | Expand 10 after
290 } 295 }
291 296
292 msvc_toolchain("winrt_x64") { 297 msvc_toolchain("winrt_x64") {
293 environment = "environment.winrt_x64" 298 environment = "environment.winrt_x64"
294 cl = "${goma_prefix}\"${vc_bin_dir}/cl.exe\"" 299 cl = "${goma_prefix}\"${vc_bin_dir}/cl.exe\""
295 is_clang = false 300 is_clang = false
296 301
297 current_cpu = "x64" 302 current_cpu = "x64"
298 current_os = current_os 303 current_os = current_os
299 } 304 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698