Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1434413002: [Sync] Re-enable testAndroidSyncSettingsPostsNotifications. (Closed)

Created:
5 years, 1 month ago by maxbogue
Modified:
5 years, 1 month ago
CC:
chromium-reviews, tim+watch_chromium.org, pvalenzuela+watch_chromium.org, maxbogue+watch_chromium.org, plaree+watch_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Re-enable testAndroidSyncSettingsPostsNotifications. BUG=527856 Committed: https://crrev.com/0e8c02ee3e3619d98ae48aceac93456c8b271af0 Cr-Commit-Position: refs/heads/master@{#361164}

Patch Set 1 #

Patch Set 2 : 10000x! #

Patch Set 3 : Remove 10000x. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M sync/android/javatests/src/org/chromium/sync/AndroidSyncSettingsTest.java View 1 2 2 chunks +2 lines, -5 lines 0 comments Download

Depends on Patchset:

Issue 1434053002 Patch 60001

Messages

Total messages: 7 (2 generated)
maxbogue
Patrick, PTAL! This test was flaky a couple months ago but I'm unable to reproduce ...
5 years, 1 month ago (2015-11-17 22:38:10 UTC) #2
pval...(no longer on Chromium)
lgtm
5 years, 1 month ago (2015-11-23 19:00:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1434413002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1434413002/40001
5 years, 1 month ago (2015-11-23 19:29:18 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 1 month ago (2015-11-23 20:16:13 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-23 20:17:12 UTC) #7
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/0e8c02ee3e3619d98ae48aceac93456c8b271af0
Cr-Commit-Position: refs/heads/master@{#361164}

Powered by Google App Engine
This is Rietveld 408576698