Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 14344005: Round corners for Files.app's new ui. (Closed)

Created:
7 years, 8 months ago by mtomasz
Modified:
7 years, 8 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, rginda+watch_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

Round corners for Files.app's new ui. This patch makes the corners rounded to match the recent mocks. Note, that this uses an experimental api. TEST=Run with flags: --file-manager-new-ui --enable-experimental-extension-apis. BUG=226912 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195125

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M chrome/browser/resources/file_manager/css/file_manager.css View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/resources/file_manager/js/background.js View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/file_manager/manifest_new_ui.json View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
mtomasz
@yoshiki: PTAL. Thanks.
7 years, 8 months ago (2013-04-18 09:26:16 UTC) #1
yoshiki
lgtm
7 years, 8 months ago (2013-04-19 01:53:41 UTC) #2
mtomasz
On 2013/04/19 01:53:41, yoshiki wrote: > lgtm Thanks!
7 years, 8 months ago (2013-04-19 01:54:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/14344005/1
7 years, 8 months ago (2013-04-19 01:55:13 UTC) #4
mtomasz
7 years, 8 months ago (2013-04-19 09:20:23 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r195125 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698