Check DEPS during presubmit before uploads.

Check DEPS during presubmit before uploads.

Also run presubmit checks before committing.

R=tsepez@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/76c6d639f46c37ba955569f507201eb3f1b613fc

[Lei Zhang, 2015-11-13 06:50:53]

thestig@chromium.org changed reviewers:
+ tsepez@chromium.org

[Lei Zhang, 2015-11-13 06:50:53]

This passes on master, so enforce it. Code is stolen verbatim from Chromium.

[Tom Sepez, 2015-11-13 17:36:20]

https://codereview.chromium.org/1434393003/diff/1/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/1434393003/diff/1/PRESUBMIT.py#newcode72
PRESUBMIT.py:72: def CheckChangeOnCommit(input_api, output_api):
Are you sure you want to turn commit time checks on in the same CL as the new
rule enforcement?  Maybe we let this CL land without commit time checks for a
few days, then flip it on if not a nuisance? Or vice versa.

[Lei Zhang, 2015-11-13 23:27:27]

https://codereview.chromium.org/1434393003/diff/1/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/1434393003/diff/1/PRESUBMIT.py#newcode72
PRESUBMIT.py:72: def CheckChangeOnCommit(input_api, output_api):
On 2015/11/13 17:36:20, Tom Sepez wrote:
> Are you sure you want to turn commit time checks on in the same CL as the new
> rule enforcement?  Maybe we let this CL land without commit time checks for a
> few days, then flip it on if not a nuisance? Or vice versa.

It succeeds locally. Do you see any reasons why checkdeps would be a nuisance?

[Tom Sepez, 2015-11-13 23:46:43]

On 2015/11/13 23:27:27, Lei Zhang wrote:
> https://codereview.chromium.org/1434393003/diff/1/PRESUBMIT.py
> File PRESUBMIT.py (right):
> 
> https://codereview.chromium.org/1434393003/diff/1/PRESUBMIT.py#newcode72
> PRESUBMIT.py:72: def CheckChangeOnCommit(input_api, output_api):
> On 2015/11/13 17:36:20, Tom Sepez wrote:
> > Are you sure you want to turn commit time checks on in the same CL as the
new
> > rule enforcement?  Maybe we let this CL land without commit time checks for
a
> > few days, then flip it on if not a nuisance? Or vice versa.
> 
> It succeeds locally. Do you see any reasons why checkdeps would be a nuisanc
Ok, LGTM if you like.  I guess I can always land --bypass

[Lei Zhang, 2015-11-13 23:55:21]

On 2015/11/13 23:46:43, Tom Sepez wrote:
> Ok, LGTM if you like.  I guess I can always land --bypass

I really don't think it'll be a bother. If it fails, then it should be a legit
failure.

I'm not going to merge this to XFA right away. XFA requires a lot more
cleanup...

[Lei Zhang, 2015-11-14 00:34:24]

Committed patchset #1 (id:1) manually as
76c6d639f46c37ba955569f507201eb3f1b613fc (presubmit successful).

[hans, 2015-11-19 20:56:12]

hans@chromium.org changed reviewers:
+ hans@chromium.org

[hans, 2015-11-19 20:56:12]

I'm getting this during "git-cl upload" both on Windows and Linux:

hwennborg@hwennborg:/usr/local/google/work/chromium/src/third_party/pdfium$ git
cl upload
Using 50% similarity for rename/copy detection. Override with --similarity.
Running presubmit upload checks ...
Traceback (most recent call last):
  File "/work/depot_tools/git_cl.py", line 3676, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/work/depot_tools/git_cl.py", line 3658, in main
    return dispatcher.execute(OptionParser(), argv)
  File "/usr/local/google/work/depot_tools/subcommand.py", line 252, in execute
    return command(parser, args[1:])
  File "/work/depot_tools/git_cl.py", line 2418, in CMDupload
    change=change)
  File "/work/depot_tools/git_cl.py", line 1109, in RunHook
    rietveld_obj=self.RpcServer())
  File "/usr/local/google/work/depot_tools/presubmit_support.py", line 1477, in
DoPresubmitChecks
    results += executer.ExecPresubmitScript(presubmit_script, filename)
  File "/usr/local/google/work/depot_tools/presubmit_support.py", line 1394, in
ExecPresubmitScript
    result = eval(function_name + '(*__args)', context)
  File "<string>", line 1, in <module>
  File "<string>", line 68, in CheckChangeOnUpload
  File "<string>", line 24, in _CheckUnwantedDependencies
ImportError: No module named checkdeps
Sending crash report ...
  args: ['/work/depot_tools/git_cl.py', 'upload']
  cwd: /usr/local/google/work/chromium/src/third_party/pd
  exception: No module named checkdeps
  host: hwennborg.mtv.corp.google.com
  stack:   File "/work/depot_tools/git_cl.py", line 3676, i
  user: hwennborg
  version: 2.7.6 (default, Jun 22 2015, 17:58:13) 
[GCC 4.8.2
A stack trace has been sent to the maintainers.

[Lei Zhang, 2015-11-19 21:28:55]

On 2015/11/19 20:56:12, hans wrote:
> I'm getting this during "git-cl upload" both on Windows and Linux:

We chatted and I think this is due to trying to upload a CL from Chromium's
third_party/pdfium, rather than from a standalone pdfium checkout. I'll see if
it is possible to reuse Chromium's buildtools.

[Lei Zhang, 2015-11-20 02:58:08]

On 2015/11/19 21:28:55, Lei Zhang wrote:
> On 2015/11/19 20:56:12, hans wrote:
> > I'm getting this during "git-cl upload" both on Windows and Linux:
> 
> We chatted and I think this is due to trying to upload a CL from Chromium's
> third_party/pdfium, rather than from a standalone pdfium checkout. I'll see if
> it is possible to reuse Chromium's buildtools.

CL to improve the presubmit: https://codereview.chromium.org/1464733002/