Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Side by Side Diff: runtime/vm/assembler_arm.h

Issue 1434323003: ARM: Don't generate memory instructions with writeback where the data and address registers are the… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | runtime/vm/assembler_arm.cc » ('j') | runtime/vm/stub_code_arm.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #ifndef VM_ASSEMBLER_ARM_H_ 5 #ifndef VM_ASSEMBLER_ARM_H_
6 #define VM_ASSEMBLER_ARM_H_ 6 #define VM_ASSEMBLER_ARM_H_
7 7
8 #ifndef VM_ASSEMBLER_H_ 8 #ifndef VM_ASSEMBLER_H_
9 #error Do not include assembler_arm.h directly; use assembler.h instead. 9 #error Do not include assembler_arm.h directly; use assembler.h instead.
10 #endif 10 #endif
(...skipping 303 matching lines...) Expand 10 before | Expand all | Expand 10 after
314 } 314 }
315 315
316 Register rm() const { 316 Register rm() const {
317 return ((kind() == IndexRegister) || (kind() == ScaledIndexRegister)) ? 317 return ((kind() == IndexRegister) || (kind() == ScaledIndexRegister)) ?
318 Instr::At(reinterpret_cast<uword>(&encoding_))->RmField() : 318 Instr::At(reinterpret_cast<uword>(&encoding_))->RmField() :
319 kNoRegister; 319 kNoRegister;
320 } 320 }
321 321
322 Mode mode() const { return static_cast<Mode>(encoding() & kModeMask); } 322 Mode mode() const { return static_cast<Mode>(encoding() & kModeMask); }
323 323
324 bool has_writeback() const {
325 return (mode() == PreIndex) || (mode() == PostIndex) ||
326 (mode() == NegPreIndex) || (mode() == NegPostIndex);
327 }
328
324 uint32_t encoding() const { return encoding_; } 329 uint32_t encoding() const { return encoding_; }
325 330
326 // Encoding for addressing mode 3. 331 // Encoding for addressing mode 3.
327 uint32_t encoding3() const; 332 uint32_t encoding3() const;
328 333
329 // Encoding for vfp load/store addressing. 334 // Encoding for vfp load/store addressing.
330 uint32_t vencoding() const; 335 uint32_t vencoding() const;
331 336
332 OffsetKind kind() const { return kind_; } 337 OffsetKind kind() const { return kind_; }
333 338
(...skipping 871 matching lines...) Expand 10 before | Expand all | Expand 10 after
1205 Register new_value, 1210 Register new_value,
1206 FieldContent old_content); 1211 FieldContent old_content);
1207 1212
1208 DISALLOW_ALLOCATION(); 1213 DISALLOW_ALLOCATION();
1209 DISALLOW_COPY_AND_ASSIGN(Assembler); 1214 DISALLOW_COPY_AND_ASSIGN(Assembler);
1210 }; 1215 };
1211 1216
1212 } // namespace dart 1217 } // namespace dart
1213 1218
1214 #endif // VM_ASSEMBLER_ARM_H_ 1219 #endif // VM_ASSEMBLER_ARM_H_
OLDNEW
« no previous file with comments | « no previous file | runtime/vm/assembler_arm.cc » ('j') | runtime/vm/stub_code_arm.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698