Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1434243002: Oilpan: add missing tracing of WebLocalFrameImpls from inspector agents. (Closed)

Created:
5 years, 1 month ago by sof
Modified:
5 years, 1 month ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Oilpan: add missing tracing of WebLocalFrameImpls from inspector agents. R=haraken BUG=553613 Committed: https://crrev.com/12c188bf958cea618103b043d8cd5811456fd390 Cr-Commit-Position: refs/heads/master@{#359314}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M third_party/WebKit/Source/web/InspectorEmulationAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/InspectorEmulationAgent.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/InspectorRenderingAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/InspectorRenderingAgent.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sof
5 years, 1 month ago (2015-11-12 10:43:12 UTC) #2
haraken
LGTM
5 years, 1 month ago (2015-11-12 14:16:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1434243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1434243002/1
5 years, 1 month ago (2015-11-12 14:53:14 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-12 14:57:29 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-12 20:07:08 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/12c188bf958cea618103b043d8cd5811456fd390
Cr-Commit-Position: refs/heads/master@{#359314}

Powered by Google App Engine
This is Rietveld 408576698