Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 # Gyp file for opts projects | 1 # Gyp file for opts projects |
| 2 { | 2 { |
| 3 'targets': [ | 3 'targets': [ |
| 4 # Due to an unfortunate intersection of lameness between gcc and gyp, | 4 # Due to an unfortunate intersection of lameness between gcc and gyp, |
| 5 # we have to build the *_SSE2.cpp files in a separate target. The | 5 # we have to build the *_SSE2.cpp files in a separate target. The |
| 6 # gcc lameness is that, in order to compile SSE2 intrinsics code, it | 6 # gcc lameness is that, in order to compile SSE2 intrinsics code, it |
| 7 # must be passed the -msse2 flag. However, with this flag, it may | 7 # must be passed the -msse2 flag. However, with this flag, it may |
| 8 # emit SSE2 instructions even for scalar code, such as the CPUID | 8 # emit SSE2 instructions even for scalar code, such as the CPUID |
| 9 # test used to test for the presence of SSE2. So that, and all other | 9 # test used to test for the presence of SSE2. So that, and all other |
| 10 # code must be compiled *without* -msse2. The gyp lameness is that it | 10 # code must be compiled *without* -msse2. The gyp lameness is that it |
| (...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 107 'sources': [ | 107 'sources': [ |
| 108 '../src/opts/SkBitmapProcState_opts_none.cpp', | 108 '../src/opts/SkBitmapProcState_opts_none.cpp', |
| 109 '../src/opts/SkBlitMask_opts_none.cpp', | 109 '../src/opts/SkBlitMask_opts_none.cpp', |
| 110 '../src/opts/SkBlitRow_opts_none.cpp', | 110 '../src/opts/SkBlitRow_opts_none.cpp', |
| 111 '../src/opts/SkBlurImage_opts_none.cpp', | 111 '../src/opts/SkBlurImage_opts_none.cpp', |
| 112 '../src/opts/SkMorphology_opts_none.cpp', | 112 '../src/opts/SkMorphology_opts_none.cpp', |
| 113 '../src/opts/SkUtils_opts_none.cpp', | 113 '../src/opts/SkUtils_opts_none.cpp', |
| 114 '../src/opts/SkXfermode_opts_none.cpp', | 114 '../src/opts/SkXfermode_opts_none.cpp', |
| 115 ], | 115 ], |
| 116 }], | 116 }], |
| 117 [ 'skia_arch_type == "arm64"', { | |
|
djsollen
2014/03/20 14:40:16
I'm inclined to stick with the way we handle arch_
djsollen
2014/03/20 15:37:27
So chromium is opting for arch_type == arm64 as we
kevin.petit
2014/03/20 16:05:09
To be honest, this has my preference as AArch64 is
| |
| 118 'sources': [ | |
| 119 '../src/opts/SkBitmapProcState_arm_neon.cpp', | |
| 120 '../src/opts/SkBitmapProcState_matrixProcs_neon.cpp', | |
| 121 '../src/opts/SkBitmapProcState_opts_arm.cpp', | |
| 122 '../src/opts/SkBlitMask_opts_arm.cpp', | |
| 123 '../src/opts/SkBlitMask_opts_arm_neon.cpp', | |
| 124 '../src/opts/SkBlitRow_opts_none.cpp', | |
| 125 '../src/opts/SkBlurImage_opts_arm.cpp', | |
| 126 '../src/opts/SkBlurImage_opts_neon.cpp', | |
| 127 '../src/opts/SkMorphology_opts_arm.cpp', | |
| 128 '../src/opts/SkMorphology_opts_neon.cpp', | |
| 129 '../src/opts/SkUtils_opts_none.cpp', | |
| 130 '../src/opts/SkXfermode_opts_arm.cpp', | |
| 131 '../src/opts/SkXfermode_opts_arm_neon.cpp', | |
| 132 ], | |
| 133 }], | |
| 117 ], | 134 ], |
| 118 }, | 135 }, |
| 119 # For the same lame reasons as what is done for skia_opts, we have to | 136 # For the same lame reasons as what is done for skia_opts, we have to |
| 120 # create another target specifically for SSSE3 code as we would not want | 137 # create another target specifically for SSSE3 code as we would not want |
| 121 # to compile the SSE2 code with -mssse3 which would potentially allow | 138 # to compile the SSE2 code with -mssse3 which would potentially allow |
| 122 # gcc to generate SSSE3 code. | 139 # gcc to generate SSSE3 code. |
| 123 { | 140 { |
| 124 'target_name': 'opts_ssse3', | 141 'target_name': 'opts_ssse3', |
| 125 'product_name': 'skia_opts_ssse3', | 142 'product_name': 'skia_opts_ssse3', |
| 126 'type': 'static_library', | 143 'type': 'static_library', |
| (...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 185 '../src/opts/SkBitmapProcState_matrix_neon.h', | 202 '../src/opts/SkBitmapProcState_matrix_neon.h', |
| 186 '../src/opts/SkBlitMask_opts_arm_neon.cpp', | 203 '../src/opts/SkBlitMask_opts_arm_neon.cpp', |
| 187 '../src/opts/SkBlitRow_opts_arm_neon.cpp', | 204 '../src/opts/SkBlitRow_opts_arm_neon.cpp', |
| 188 '../src/opts/SkBlurImage_opts_neon.cpp', | 205 '../src/opts/SkBlurImage_opts_neon.cpp', |
| 189 '../src/opts/SkMorphology_opts_neon.cpp', | 206 '../src/opts/SkMorphology_opts_neon.cpp', |
| 190 '../src/opts/SkXfermode_opts_arm_neon.cpp', | 207 '../src/opts/SkXfermode_opts_arm_neon.cpp', |
| 191 ], | 208 ], |
| 192 }, | 209 }, |
| 193 ], | 210 ], |
| 194 } | 211 } |
| OLD | NEW |