Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Unified Diff: runtime/vm/flow_graph_range_analysis.cc

Issue 1434213005: VM: Fix imprecision in array bounds check elimination. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/compiler.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_range_analysis.cc
diff --git a/runtime/vm/flow_graph_range_analysis.cc b/runtime/vm/flow_graph_range_analysis.cc
index 35a7a5d80aaafd548ca80891de34ad5b35a18c1e..4e3eaaf8ed055943094297f7eb453d385267d73e 100644
--- a/runtime/vm/flow_graph_range_analysis.cc
+++ b/runtime/vm/flow_graph_range_analysis.cc
@@ -3126,14 +3126,7 @@ bool CheckArrayBoundInstr::IsRedundant(const RangeBoundary& length) {
return false;
}
- RangeBoundary max = CanonicalizeBoundary(
- RangeBoundary::FromDefinition(index()->definition()),
- RangeBoundary::PositiveInfinity());
-
- if (max.OverflowedSmi()) {
- return false;
- }
-
+ RangeBoundary max = RangeBoundary::FromDefinition(index()->definition());
RangeBoundary max_upper = max.UpperBound();
RangeBoundary length_lower = length.LowerBound();
« no previous file with comments | « runtime/vm/compiler.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698