Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/hydrogen.h

Issue 143413019: Load elimination fix with a test case. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Review notes applied Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/code-stubs-hydrogen.cc ('k') | src/hydrogen.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1347 matching lines...) Expand 10 before | Expand all | Expand 10 after
1358 ElementsKind elements_kind, 1358 ElementsKind elements_kind,
1359 bool is_store, 1359 bool is_store,
1360 LoadKeyedHoleMode load_mode = NEVER_RETURN_HOLE); 1360 LoadKeyedHoleMode load_mode = NEVER_RETURN_HOLE);
1361 1361
1362 HLoadNamedField* BuildLoadNamedField(HValue* object, HObjectAccess access); 1362 HLoadNamedField* BuildLoadNamedField(HValue* object, HObjectAccess access);
1363 HInstruction* AddLoadNamedField(HValue* object, HObjectAccess access); 1363 HInstruction* AddLoadNamedField(HValue* object, HObjectAccess access);
1364 HInstruction* AddLoadStringInstanceType(HValue* string); 1364 HInstruction* AddLoadStringInstanceType(HValue* string);
1365 HInstruction* AddLoadStringLength(HValue* string); 1365 HInstruction* AddLoadStringLength(HValue* string);
1366 HStoreNamedField* AddStoreMapNoWriteBarrier(HValue* object, HValue* map) { 1366 HStoreNamedField* AddStoreMapNoWriteBarrier(HValue* object, HValue* map) {
1367 HStoreNamedField* store_map = Add<HStoreNamedField>( 1367 HStoreNamedField* store_map = Add<HStoreNamedField>(
1368 object, HObjectAccess::ForMap(), map); 1368 object, HObjectAccess::ForMap(), map, INITIALIZING_STORE);
1369 store_map->SkipWriteBarrier(); 1369 store_map->SkipWriteBarrier();
1370 return store_map; 1370 return store_map;
1371 } 1371 }
1372 HStoreNamedField* AddStoreMapConstant(HValue* object, Handle<Map> map); 1372 HStoreNamedField* AddStoreMapConstant(HValue* object, Handle<Map> map);
1373 HStoreNamedField* AddStoreMapConstantNoWriteBarrier(HValue* object, 1373 HStoreNamedField* AddStoreMapConstantNoWriteBarrier(HValue* object,
1374 Handle<Map> map) { 1374 Handle<Map> map) {
1375 HStoreNamedField* store_map = AddStoreMapConstant(object, map); 1375 HStoreNamedField* store_map = AddStoreMapConstant(object, map);
1376 store_map->SkipWriteBarrier(); 1376 store_map->SkipWriteBarrier();
1377 return store_map; 1377 return store_map;
1378 } 1378 }
(...skipping 1317 matching lines...) Expand 10 before | Expand all | Expand 10 after
2696 } 2696 }
2697 2697
2698 private: 2698 private:
2699 HGraphBuilder* builder_; 2699 HGraphBuilder* builder_;
2700 }; 2700 };
2701 2701
2702 2702
2703 } } // namespace v8::internal 2703 } } // namespace v8::internal
2704 2704
2705 #endif // V8_HYDROGEN_H_ 2705 #endif // V8_HYDROGEN_H_
OLDNEW
« no previous file with comments | « src/code-stubs-hydrogen.cc ('k') | src/hydrogen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698