Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 143413018: A64: Fix 'step instruction' ('si') in debugger (Closed)

Created:
6 years, 11 months ago by m.m.capewell
Modified:
6 years, 11 months ago
Reviewers:
baptiste.afsa1
CC:
v8-dev
Visibility:
Public.

Description

A64: Fix 'step instruction' ('si') in debugger Fix step instruction, disassemble the instructions executed by it, and add a blank line after disassembling an instruction to separate it from the instruction at the pc. BUG=none R=baptiste.afsa@arm.com Committed: https://code.google.com/p/v8/source/detail?r=18831

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -19 lines) Patch
M src/a64/simulator-a64.cc View 2 chunks +22 lines, -19 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
m.m.capewell
6 years, 11 months ago (2014-01-24 14:26:18 UTC) #1
baptiste.afsa1
lgtm
6 years, 11 months ago (2014-01-24 15:11:31 UTC) #2
m.m.capewell
6 years, 11 months ago (2014-01-24 15:19:43 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r18831 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698