Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1434123003: Update Google C++ Style guide URL in c++11.html (Closed)

Created:
5 years, 1 month ago by vabr (Chromium)
Modified:
5 years, 1 month ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update Google C++ Style guide URL in c++11.html The Google C++ style guide moved: https://google-styleguide.googlecode.com/svn/trunk/cppguide.html -> https://google.github.io/styleguide/cppguide.html. While that redirect works on server-side, it discards the fragment identifier, making the links less useful. This CL changes the Styleguide links to the new URL. The only issue has been with #Initialization, which does not have a corresponding entry in the new Styleguide. Looking at similar entries, there is https://google.github.io/styleguide/cppguide.html#Delegating_and_inheriting_constructors which mentions in-class member initialization, but does not seem to explicitly comment on that. This CL therefore drops the #Initialization Styleguide link from c++11.html completely. R=thakis@chromium.org BUG=None Committed: https://crrev.com/63d398a84ab2d1d6718382b3bc60f0c7d32f3de1 Cr-Commit-Position: refs/heads/master@{#359325}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -13 lines) Patch
M styleguide/c++/c++11.html View 12 chunks +12 lines, -13 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
vabr (Chromium)
Hi Nico, PTAL. The only problematic part seems to be #Initialization, mentioned in the CL ...
5 years, 1 month ago (2015-11-12 14:16:14 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1434123003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1434123003/1
5 years, 1 month ago (2015-11-12 14:17:47 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-12 14:27:09 UTC) #6
Nico
lgtm, thanks
5 years, 1 month ago (2015-11-12 15:14:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1434123003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1434123003/1
5 years, 1 month ago (2015-11-12 15:44:47 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-12 15:48:42 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-11-12 20:07:42 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/63d398a84ab2d1d6718382b3bc60f0c7d32f3de1
Cr-Commit-Position: refs/heads/master@{#359325}

Powered by Google App Engine
This is Rietveld 408576698