Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1434093003: Oilpan: add missing tracing of PopupMenuImpl::m_chromeClient. (Closed)

Created:
5 years, 1 month ago by sof
Modified:
5 years, 1 month ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Oilpan: add missing tracing of PopupMenuImpl::m_chromeClient. R=haraken BUG=553613 Committed: https://crrev.com/c3f683678512035cceb2426a590991d28ccf4d9e Cr-Commit-Position: refs/heads/master@{#359306}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M third_party/WebKit/Source/web/PopupMenuImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/PopupMenuImpl.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sof
5 years, 1 month ago (2015-11-12 10:04:16 UTC) #2
haraken
LGTM
5 years, 1 month ago (2015-11-12 10:15:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1434093003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1434093003/1
5 years, 1 month ago (2015-11-12 11:49:36 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-12 12:36:02 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-12 20:06:47 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/c3f683678512035cceb2426a590991d28ccf4d9e
Cr-Commit-Position: refs/heads/master@{#359306}

Powered by Google App Engine
This is Rietveld 408576698