Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(852)

Unified Diff: sync/android/javatests/src/org/chromium/sync/AndroidSyncSettingsTest.java

Issue 1434053002: [Sync] Fix flaky AndroidSyncSettings tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sync/test/android/javatests/src/org/chromium/sync/test/util/MockAccountManager.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/android/javatests/src/org/chromium/sync/AndroidSyncSettingsTest.java
diff --git a/sync/android/javatests/src/org/chromium/sync/AndroidSyncSettingsTest.java b/sync/android/javatests/src/org/chromium/sync/AndroidSyncSettingsTest.java
index ef26ce2e7ceb343dc90e772ab52a3b7a5cb181d8..e89c338547caad3976264ad0c9881c963db30efd 100644
--- a/sync/android/javatests/src/org/chromium/sync/AndroidSyncSettingsTest.java
+++ b/sync/android/javatests/src/org/chromium/sync/AndroidSyncSettingsTest.java
@@ -7,7 +7,6 @@ package org.chromium.sync;
import android.accounts.Account;
import android.content.Context;
import android.os.Bundle;
-import android.test.FlakyTest;
import android.test.InstrumentationTestCase;
import android.test.suitebuilder.annotation.SmallTest;
@@ -145,18 +144,14 @@ public class AndroidSyncSettingsTest extends InstrumentationTestCase {
});
}
- @FlakyTest
- /*
- * http://crbug.com/554154
- * @SmallTest
- * @Feature({"Sync"})
- */
+ @SmallTest
+ @Feature({"Sync"})
public void testAccountInitialization() throws InterruptedException {
// mAccount was set to be syncable and not have periodic syncs.
assertEquals(1, mSyncContentResolverDelegate.mSetIsSyncableCalls);
assertEquals(1, mSyncContentResolverDelegate.mRemovePeriodicSyncCalls);
AndroidSyncSettings.updateAccount(mContext, null);
- getInstrumentation().waitForIdleSync();
+ mAccountManager.waitForGetAccountsTask();
// mAccount was set to be not syncable.
assertEquals(2, mSyncContentResolverDelegate.mSetIsSyncableCalls);
assertEquals(1, mSyncContentResolverDelegate.mRemovePeriodicSyncCalls);
@@ -357,14 +352,12 @@ public class AndroidSyncSettingsTest extends InstrumentationTestCase {
mSyncSettingsObserver.receivedNotification());
}
- /*@SmallTest
- @Feature({"Sync"})*/
- // http://crbug.com/527856
- @DisabledTest
+ @SmallTest
+ @Feature({"Sync"})
public void testIsSyncableOnSigninAndNotOnSignout() throws InterruptedException {
assertTrue(mSyncContentResolverDelegate.getIsSyncable(mAccount, mAuthority) == 1);
AndroidSyncSettings.updateAccount(mContext, null);
- getInstrumentation().waitForIdleSync();
+ mAccountManager.waitForGetAccountsTask();
assertTrue(mSyncContentResolverDelegate.getIsSyncable(mAccount, mAuthority) == 0);
AndroidSyncSettings.updateAccount(mContext, mAccount);
assertTrue(mSyncContentResolverDelegate.getIsSyncable(mAccount, mAuthority) == 1);
« no previous file with comments | « no previous file | sync/test/android/javatests/src/org/chromium/sync/test/util/MockAccountManager.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698