Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Issue 1434033004: Update libsrtp to upstream commit be95365fbb4788b688cab7af61c65b7989055fb4 (Closed)

Created:
5 years, 1 month ago by joachim
Modified:
5 years, 1 month ago
Reviewers:
jiayl, juberti2, juberti
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/deps/libsrtp@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update libsrtp to upstream commit be95365fbb4788b688cab7af61c65b7989055fb4 This CL updates libsrtp 1.5.x to the latest upstream commit in the "1_5_x_throttle" branch. Notable changes: - Increase maximum tag length to 16 bytes to allow for GCM cipher suite. - Prevent potential DoS attack due to lack of bounds checking on RTP header CSRC count and extension header length. Credit goes to Randell Jesup and the Firefox team for reporting this issue. R=juberti@chromium.org Committed: https://chromium.googlesource.com/chromium/deps/libsrtp/+/b8dd754b4fa05fd4cf1c2e8dc3b1ac976280e41a

Patch Set 1 #

Patch Set 2 : Updated to libsrtp be95365fbb4788b688cab7af61c65b7989055fb4 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3607 lines) Patch
M srtp/Makefile.in View 3 chunks +3 lines, -2 lines 0 comments Download
M srtp/VERSION View 1 chunk +1 line, -1 line 0 comments Download
D srtp/doc/draft-irtf-cfrg-icm-00.txt View 1 chunk +0 lines, -460 lines 0 comments Download
D srtp/doc/rfc3711.txt View 1 chunk +0 lines, -3139 lines 0 comments Download
M srtp/include/srtp.h View 1 chunk +1 line, -1 line 0 comments Download
M srtp/srtp/srtp.c View 1 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
joachim
Ptal
5 years, 1 month ago (2015-11-17 22:02:05 UTC) #4
juberti2
lgtm
5 years, 1 month ago (2015-11-18 04:22:53 UTC) #6
joachim
On 2015/11/18 04:22:53, juberti2 wrote: > lgtm Thanks, I think I need somebody to land ...
5 years, 1 month ago (2015-11-18 08:14:40 UTC) #7
jiayl
5 years, 1 month ago (2015-11-18 17:21:23 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
b8dd754b4fa05fd4cf1c2e8dc3b1ac976280e41a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698