Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1974)

Issue 143403005: Make the timer in SMILTimeContainer more of an implementation detail (Closed)

Created:
6 years, 10 months ago by fs
Modified:
6 years, 10 months ago
CC:
blink-reviews, ed+blinkwatch_opera.com, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), rwlbuis, dstockwell, Timothy Loh, krit, f(malita), gyuyoung.kim_webkit.org, darktears, pdr, Stephen Chennney, Steve Block, dino_apple.com, Eric Willigers
Visibility:
Public.

Description

Make the timer in SMILTimeContainer more of an implementation detail Add a few new methods to represent the different actions required: scheduleAnimationFrame(SMILTime fireTime) immediateAnimationFrame() cancelAnimationFrame() and replace uses of m_timer.foo() and startTimer with the appropriate method. BUG=231576 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166497

Patch Set 1 #

Total comments: 1

Patch Set 2 : scheduleAnimationFrameSoon. #

Patch Set 3 : Not Soon anymore. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -14 lines) Patch
M Source/core/svg/animation/SMILTimeContainer.h View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M Source/core/svg/animation/SMILTimeContainer.cpp View 1 2 9 chunks +30 lines, -13 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
fs
6 years, 10 months ago (2014-02-04 17:17:01 UTC) #1
pdr.
Another fantastic patch, thank you! LGTM with one nit. https://codereview.chromium.org/143403005/diff/1/Source/core/svg/animation/SMILTimeContainer.cpp File Source/core/svg/animation/SMILTimeContainer.cpp (right): https://codereview.chromium.org/143403005/diff/1/Source/core/svg/animation/SMILTimeContainer.cpp#newcode223 Source/core/svg/animation/SMILTimeContainer.cpp:223: ...
6 years, 10 months ago (2014-02-04 18:45:57 UTC) #2
fs
On 2014/02/04 18:45:57, pdr wrote: > Another fantastic patch, thank you! > > LGTM with ...
6 years, 10 months ago (2014-02-05 12:43:21 UTC) #3
fs
The CQ bit was checked by fs@opera.com
6 years, 10 months ago (2014-02-05 12:43:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/143403005/90001
6 years, 10 months ago (2014-02-05 12:43:43 UTC) #5
commit-bot: I haz the power
6 years, 10 months ago (2014-02-05 13:57:47 UTC) #6
Message was sent while issue was closed.
Change committed as 166497

Powered by Google App Engine
This is Rietveld 408576698