chrome/browser/devtools/devtools_window.cc - Issue 1433953002: Implement a ShowSecurityPanel() call in the browser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/devtools_window.cc

Issue 1433953002: Implement a ShowSecurityPanel() call in the browser. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Re-implement showConsole using showPanel. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/devtools/devtools_toggle_action.cc ('k') | third_party/WebKit/Source/devtools/front_end/components/InspectorView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/devtools/devtools_window.cc

diff --git a/chrome/browser/devtools/devtools_window.cc b/chrome/browser/devtools/devtools_window.cc

index 41863af5b69883153a826134e32132da0dd64d0c..0943fa8ba3ff4193da41628032f88c7a34865e0f 100644

--- a/chrome/browser/devtools/devtools_window.cc

+++ b/chrome/browser/devtools/devtools_window.cc

@@ -1196,11 +1196,18 @@ BrowserWindow* DevToolsWindow::GetInspectedBrowserWindow() {

void DevToolsWindow::DoAction(const DevToolsToggleAction& action) {

switch (action.type()) {

- case DevToolsToggleAction::kShowConsole:

- bindings_->CallClientFunction(

- "DevToolsAPI.showConsole", NULL, NULL, NULL);

+ case DevToolsToggleAction::kShowConsole: {

+ base::StringValue panel_name("console");

+ bindings_->CallClientFunction("DevToolsAPI.showPanel", &panel_name, NULL,

+ NULL);

break;

+ }

+ case DevToolsToggleAction::kShowSecurityPanel: {

+ base::StringValue panel_name("security");

+ bindings_->CallClientFunction("DevToolsAPI.showPanel", &panel_name, NULL,

+ NULL);

+ break;

+ }

case DevToolsToggleAction::kInspect:

bindings_->CallClientFunction(

"DevToolsAPI.enterInspectElementMode", NULL, NULL, NULL);