Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(796)

Unified Diff: chrome/browser/devtools/devtools_window.cc

Issue 1433953002: Implement a ShowSecurityPanel() call in the browser. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Implement a general showPanel command. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/devtools/devtools_window.cc
diff --git a/chrome/browser/devtools/devtools_window.cc b/chrome/browser/devtools/devtools_window.cc
index 41863af5b69883153a826134e32132da0dd64d0c..a0242d415af595bc9324e86df05113c7991ea8fd 100644
--- a/chrome/browser/devtools/devtools_window.cc
+++ b/chrome/browser/devtools/devtools_window.cc
@@ -1195,12 +1195,19 @@ BrowserWindow* DevToolsWindow::GetInspectedBrowserWindow() {
}
void DevToolsWindow::DoAction(const DevToolsToggleAction& action) {
+
pfeldman 2015/11/13 01:33:49 revert
switch (action.type()) {
case DevToolsToggleAction::kShowConsole:
bindings_->CallClientFunction(
"DevToolsAPI.showConsole", NULL, NULL, NULL);
pfeldman 2015/11/13 01:33:49 I meant that you refactor this one to use the new
lgarron 2015/11/13 01:34:46 I was gonna do this in a follow-up CL. Would you p
break;
+ case DevToolsToggleAction::kShowSecurityPanel: {
+ base::StringValue panel_name("security");
+ bindings_->CallClientFunction("DevToolsAPI.showPanel", &panel_name, NULL,
+ NULL);
+ break;
+ }
case DevToolsToggleAction::kInspect:
bindings_->CallClientFunction(
"DevToolsAPI.enterInspectElementMode", NULL, NULL, NULL);

Powered by Google App Engine
This is Rietveld 408576698