DevTools: [SSP] adding new property should be more predictable

DevTools: [SSP] adding new property should be more predictable

Whitelist selectable elements to avoid excessive text "selectability".

BUG=554454
R=pfeldman, dgozman

Committed: https://crrev.com/491172b142d4b302674c4552eea14cecd0421dbc
Cr-Commit-Position: refs/heads/master@{#360494}

[lushnikov, 2015-11-11 07:27:51]

ptal

[lushnikov, 2015-11-11 07:27:55]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-11 07:28:05]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1433903002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1433903002/1

[lushnikov, 2015-11-11 07:38:20]

Description was changed from

==========
DevTools: [SSP] adding new property should be more predictable

Currently, adding a new property will not happen in case of non-empty
selection. However, the selection could technically be non-collapsed,
but still negligable for the current case as it doesn't hold any
characters.

One example of such a situation is a selection that starts
right after ";" character of the property and ends right before the
next property text.

This patch replaces |isComponentSelectionCollapsed| calls in editing
with |isComponentSelectionEmpty| which verifies that selection doesn't
have any sane data.

BUG=554454
R=pfeldman, dgozman
==========

to

==========
DevTools: [SSP] adding new property should be more predictable

Currently, adding a new property will not happen in case of non-empty
selection. However, the selection could technically be non-collapsed,
but still non-visible as it doesn't hold any
characters.

One example of such a situation is a selection that starts
right after ";" character of the property and ends right before the
next property text.

This patch replaces |isComponentSelectionCollapsed| calls in editing
with |isComponentSelectionEmpty| which verifies that selection doesn't
have any sane data.

BUG=554454
R=pfeldman, dgozman
==========

[commit-bot: I haz the power, 2015-11-11 08:15:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-11 08:15:54]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[dgozman, 2015-11-11 18:07:46]

I failed to repro the bug in 10 tries.

[lushnikov, 2015-11-11 19:11:54]

On 2015/11/11 18:07:46, dgozman wrote:
> I failed to repro the bug in 10 tries.

Found a better repro - see bug

[lushnikov, 2015-11-14 02:26:18]

ping. 
Everybody will benefit from the patch.

[lushnikov, 2015-11-18 21:54:54]

Switched to User-Select: none approach we've discussed offline. ptal

[dgozman, 2015-11-19 00:33:20]

lgtm

Please change patch description.

[lushnikov, 2015-11-19 00:33:54]

Description was changed from

==========
DevTools: [SSP] adding new property should be more predictable

Currently, adding a new property will not happen in case of non-empty
selection. However, the selection could technically be non-collapsed,
but still non-visible as it doesn't hold any
characters.

One example of such a situation is a selection that starts
right after ";" character of the property and ends right before the
next property text.

This patch replaces |isComponentSelectionCollapsed| calls in editing
with |isComponentSelectionEmpty| which verifies that selection doesn't
have any sane data.

BUG=554454
R=pfeldman, dgozman
==========

to

==========
DevTools: [SSP] adding new property should be more predictable

Whitelist selectable elements to avoid excessive text "selectability".

BUG=554454
R=pfeldman, dgozman
==========

[lushnikov, 2015-11-19 00:34:01]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2015-11-19 00:38:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1433903002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1433903002/20001

[commit-bot: I haz the power, 2015-11-19 02:29:04]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-19 02:30:27]

Patchset 2 (id:??) landed as
https://crrev.com/491172b142d4b302674c4552eea14cecd0421dbc
Cr-Commit-Position: refs/heads/master@{#360494}

[lushnikov, 2015-11-20 00:33:33]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1465713002/ by lushnikov@chromium.org.

The reason for reverting is: This patch makes selecting properties in SSP
tedious.
Example:
1. try selecting all properties of some rule
2. left-click in the empty space of the rule does not always removes selection.