chrome/browser/page_load_metrics/page_load_metrics_initialize.cc - Issue 1433893002: Add StaleWhileRevalidateExperiment histograms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/page_load_metrics_initialize.cc

Issue 1433893002: Add StaleWhileRevalidateExperiment histograms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@s-w-r-dafsa

Patch Set: Fix compile error. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/page_load_metrics/observers/stale_while_revalidate_metrics_observer.cc ('k') | chrome/browser/ui/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/page_load_metrics_initialize.cc

diff --git a/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc b/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc

index 16542e41e6338063bcd575c3a0a5603b68926be9..18e1403279abc84f374dc13916a37fb1ecf112ad 100644

--- a/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc

+++ b/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc

@@ -7,6 +7,7 @@

#include "chrome/browser/browser_process.h"

#include "chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h"

#include "chrome/browser/page_load_metrics/observers/google_captcha_observer.h"

+#include "chrome/browser/page_load_metrics/observers/stale_while_revalidate_metrics_observer.h"

#include "chrome/browser/prerender/prerender_contents.h"

#include "components/page_load_metrics/browser/metrics_web_contents_observer.h"

#include "components/rappor/rappor_service.h"

@@ -23,6 +24,11 @@ void RegisterPageLoadMetricsObservers(

metrics->AddObserver(new FromGWSPageLoadMetricsObserver(metrics));

metrics->AddObserver(

new google_captcha_observer::GoogleCaptchaObserver(metrics));

+ // StaleWhileRevalidateMetricsObserver also deletes itself from

+ // OnPageLoadMetricsGoingAway.

+ // TODO(ricea): Remove this in April 2016 or before. crbug.com/348877

+ metrics->AddObserver(

+ new chrome::StaleWhileRevalidateMetricsObserver(metrics));

}

} // namespace