Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issue 1433883003: GC plugin: RefPtr<T> is legal if T is RefCountedGC-derived. (Closed)

Created:
5 years, 1 month ago by sof
Modified:
5 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GC plugin: RefPtr<T> is legal if T is RefCountedGC-derived. Allow RefPtr<T> uses for classes that derive from RefCountedGarbageCollected<T>. R= BUG=553613 Committed: https://crrev.com/c175b30bb17b947d49597d1391a5542692fce3eb Cr-Commit-Position: refs/heads/master@{#359074}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -1 line) Patch
M tools/clang/blink_gc_plugin/CheckFieldsVisitor.cpp View 1 chunk +7 lines, -1 line 0 comments Download
M tools/clang/blink_gc_plugin/Config.h View 1 chunk +5 lines, -0 lines 0 comments Download
M tools/clang/blink_gc_plugin/RecordInfo.h View 1 chunk +1 line, -0 lines 0 comments Download
M tools/clang/blink_gc_plugin/RecordInfo.cpp View 1 chunk +10 lines, -0 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/heap/stubs.h View 1 chunk +3 lines, -0 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/ref_ptr_to_gc_managed_class.h View 1 chunk +8 lines, -0 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/ref_ptr_to_gc_managed_class.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
sof
please take a look.
5 years, 1 month ago (2015-11-11 08:20:00 UTC) #2
haraken
LGTM +thakis and +hans for the plugin change
5 years, 1 month ago (2015-11-11 09:31:34 UTC) #4
sof
On 2015/11/11 09:31:34, haraken wrote: > LGTM > > +thakis and +hans for the plugin ...
5 years, 1 month ago (2015-11-11 09:42:55 UTC) #5
hans
lgtm
5 years, 1 month ago (2015-11-11 09:43:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1433883003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1433883003/1
5 years, 1 month ago (2015-11-11 09:59:03 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-11 10:04:27 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-11-11 10:05:06 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c175b30bb17b947d49597d1391a5542692fce3eb
Cr-Commit-Position: refs/heads/master@{#359074}

Powered by Google App Engine
This is Rietveld 408576698