Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1433803002: Get rid of _FX_JPEG_TURBO_ (Closed)

Created:
5 years, 1 month ago by Lei Zhang
Modified:
5 years, 1 month ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Get rid of _FX_JPEG_TURBO_ Instead, set the libjpeg to use via GYP/GN. R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/16f26fb7621c8ee554f4d7c5b4c1972eb0ed7065

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -120 lines) Patch
M third_party/libjpeg/fpdfapi_jcapimin.c View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/libjpeg/fpdfapi_jcapistd.c View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/libjpeg/fpdfapi_jccoefct.c View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/libjpeg/fpdfapi_jccolor.c View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/libjpeg/fpdfapi_jcdctmgr.c View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/libjpeg/fpdfapi_jchuff.c View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/libjpeg/fpdfapi_jcinit.c View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/libjpeg/fpdfapi_jcmainct.c View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/libjpeg/fpdfapi_jcmarker.c View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/libjpeg/fpdfapi_jcmaster.c View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/libjpeg/fpdfapi_jcomapi.c View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/libjpeg/fpdfapi_jcparam.c View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/libjpeg/fpdfapi_jcphuff.c View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/libjpeg/fpdfapi_jcprepct.c View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/libjpeg/fpdfapi_jcsample.c View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/libjpeg/fpdfapi_jctrans.c View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/libjpeg/fpdfapi_jdapimin.c View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/libjpeg/fpdfapi_jdapistd.c View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/libjpeg/fpdfapi_jdcoefct.c View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/libjpeg/fpdfapi_jdcolor.c View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/libjpeg/fpdfapi_jddctmgr.c View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/libjpeg/fpdfapi_jdhuff.c View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/libjpeg/fpdfapi_jdinput.c View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/libjpeg/fpdfapi_jdmainct.c View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/libjpeg/fpdfapi_jdmarker.c View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/libjpeg/fpdfapi_jdmaster.c View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/libjpeg/fpdfapi_jdmerge.c View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/libjpeg/fpdfapi_jdphuff.c View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/libjpeg/fpdfapi_jdpostct.c View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/libjpeg/fpdfapi_jdsample.c View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/libjpeg/fpdfapi_jdtrans.c View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/libjpeg/fpdfapi_jerror.c View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/libjpeg/fpdfapi_jfdctfst.c View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/libjpeg/fpdfapi_jfdctint.c View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/libjpeg/fpdfapi_jidctfst.c View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/libjpeg/fpdfapi_jidctint.c View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/libjpeg/fpdfapi_jidctred.c View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/libjpeg/fpdfapi_jmemmgr.c View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/libjpeg/fpdfapi_jmemnobs.c View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/libjpeg/fpdfapi_jutils.c View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Lei Zhang
Mechanical change.
5 years, 1 month ago (2015-11-10 20:09:50 UTC) #2
Tom Sepez
RS LGTM based on a few samples.
5 years, 1 month ago (2015-11-10 20:32:10 UTC) #3
Lei Zhang
5 years, 1 month ago (2015-11-10 21:17:45 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
16f26fb7621c8ee554f4d7c5b4c1972eb0ed7065 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698