Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: src/IceAssemblerARM32.cpp

Issue 1433743002: Add POP instruction to ARM integrated assembler. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Clean up push/pop. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/IceAssemblerARM32.cpp
diff --git a/src/IceAssemblerARM32.cpp b/src/IceAssemblerARM32.cpp
index d849c54bff0414d7366d32f6d2346b932e75224d..0fdddfbf1ea83d901ecc35787a4365ffafacdbc7 100644
--- a/src/IceAssemblerARM32.cpp
+++ b/src/IceAssemblerARM32.cpp
@@ -906,11 +906,38 @@ void AssemblerARM32::orr(const Operand *OpRd, const Operand *OpRn,
emitType01(Orr, OpRd, OpRn, OpSrc1, SetFlags, Cond);
}
+void AssemblerARM32::pop(const Operand *OpRt, CondARM32::Cond Cond) {
+ // POP - ARM section A8.8.132, encoding A2:
+ // pop<c> {Rt}
+ //
+ // cccc010010011101dddd000000000100 where dddd=Rt and cccc=Cond.
+ IValueT Rt;
+ if (decodeOperand(OpRt, Rt) != DecodedAsRegister)
+ return setNeedsTextFixup();
+ assert(Rt != RegARM32::Encoded_Reg_sp);
+ // Same as load instruction.
+ constexpr bool IsLoad = true;
+ constexpr bool IsByte = false;
+ IValueT Address = decodeImmRegOffset(RegARM32::Encoded_Reg_sp, kWordSize,
+ OperandARM32Mem::PostIndex);
+ emitMemOp(Cond, kInstTypeMemImmediate, IsLoad, IsByte, Rt, Address);
+}
+
+void AssemblerARM32::popList(const IValueT Registers, CondARM32::Cond Cond) {
+ // POP - ARM section A8.*.131, encoding A1:
+ // pop<c> <registers>
+ //
+ // cccc100010111101rrrrrrrrrrrrrrrr where cccc=Cond and
+ // rrrrrrrrrrrrrrrr=Registers (one bit for each GP register).
+ constexpr bool IsLoad = true;
+ emitMultiMemOp(Cond, IA_W, IsLoad, RegARM32::Encoded_Reg_sp, Registers);
+}
+
void AssemblerARM32::push(const Operand *OpRt, CondARM32::Cond Cond) {
// PUSH - ARM section A8.8.133, encoding A2:
// push<c> {Rt}
//
- // cccc010100101101dddd000000000100 where dddd=Rd and cccc=Cond.
+ // cccc010100101101dddd000000000100 where dddd=Rt and cccc=Cond.
IValueT Rt;
if (decodeOperand(OpRt, Rt) != DecodedAsRegister)
return setNeedsTextFixup();
« no previous file with comments | « src/IceAssemblerARM32.h ('k') | src/IceInstARM32.h » ('j') | src/IceInstARM32.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698