Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: src/DartARM32/assembler_arm.h

Issue 1433743002: Add POP instruction to ARM integrated assembler. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Fix issues in last patch. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/DartARM32/assembler_arm.cc » ('j') | src/IceInstARM32.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/DartARM32/assembler_arm.h
diff --git a/src/DartARM32/assembler_arm.h b/src/DartARM32/assembler_arm.h
index 63a1ef8fed3eeb05d0feda480123f3f1522f99bc..dbc1873fef73df35322ce92cd35b62d08d17c897 100644
--- a/src/DartARM32/assembler_arm.h
+++ b/src/DartARM32/assembler_arm.h
@@ -576,11 +576,14 @@ class Assembler : public ValueObject {
void ldrd(Register rd, Register rn, int32_t offset, Condition cond = AL);
void strd(Register rd, Register rn, int32_t offset, Condition cond = AL);
+#if 0
+ // Folded into ARM32::AssemblerARM32::popList(), since it is its only use (and
+ // doesn't implement ARM LDM instructions).
void ldm(BlockAddressMode am, Register base,
RegList regs, Condition cond = AL);
-#if 0
- // Folded into ARM32::AssemblerARM32::pushList(), since it is its only
- // use (and doesn't implement ARM STM instruction).
+
+ // Folded into ARM32::AssemblerARM32::pushList(), since it is its only use
+ // (and doesn't implement ARM STM instruction).
void stm(BlockAddressMode am, Register base,
RegList regs, Condition cond = AL);
#endif
@@ -936,15 +939,16 @@ class Assembler : public ValueObject {
#if 0
// Moved to ARM32::AssemblerARM32::push().
void Push(Register rd, Condition cond = AL);
-#endif
+
+ // Moved to ARM32::AssemblerARM32::pop().
void Pop(Register rd, Condition cond = AL);
-#if 0
- // Moved to ARM32::AssemblerARM32::pushList();
+ // Moved to ARM32::AssemblerARM32::pushList().
void PushList(RegList regs, Condition cond = AL);
-#endif
- void PopList(RegList regs, Condition cond = AL);
+ // Moved to ARM32::AssemblerARM32::popList().
+ void PopList(RegList regs, Condition cond = AL);
+#endif
void MoveRegister(Register rd, Register rm, Condition cond = AL);
// Convenience shift instructions. Use mov instruction with shifter operand
« no previous file with comments | « no previous file | src/DartARM32/assembler_arm.cc » ('j') | src/IceInstARM32.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698