net/quic/quic_framer.h - Issue 1433703005: Pass in connection ID and supported version to QuicFramer::BuildVersionNegotiationPacket, instead …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_framer.h

Issue 1433703005: Pass in connection ID and supported version to QuicFramer::BuildVersionNegotiationPacket, instead … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@106947577

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/quic_framer.h

diff --git a/net/quic/quic_framer.h b/net/quic/quic_framer.h

index 0bc3299295e244cad409e33d227094ca961207e4..53ca1934380157e6540a08baf6fe4c3ded5eba26 100644

--- a/net/quic/quic_framer.h

+++ b/net/quic/quic_framer.h

@@ -304,9 +304,10 @@ class NET_EXPORT_PRIVATE QuicFramer {

static QuicEncryptedPacket* BuildPublicResetPacket(

const QuicPublicResetPacket& packet);

- QuicEncryptedPacket* BuildVersionNegotiationPacket(

- const QuicPacketPublicHeader& header,

- const QuicVersionVector& supported_versions);

+ // Returns a new version negotiation packet, owned by the caller.

+ static QuicEncryptedPacket* BuildVersionNegotiationPacket(

+ QuicConnectionId connection_id,

+ const QuicVersionVector& versions);

// SetDecrypter sets the primary decrypter, replacing any that already exists,

// and takes ownership. If an alternative decrypter is in place then the

« no previous file with comments | « net/quic/quic_connection_test.cc ('k') | net/quic/quic_framer.cc » ('j') | no next file with comments »