Issue 1433693004: mojo_benchmark: aggregate results over multiple runs.

Issue 1433693004: mojo_benchmark: aggregate results over multiple runs. (Closed)

Created:
5 years, 1 month ago by ppi

Modified:
5 years, 1 month ago

Reviewers:
qsr

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

mojo_benchmark: aggregate results over multiple runs. This patch allows to pass `--aggregate N` to `mojo_benchmark`, causing the script to run each benchmark N times and aggregate the results. When uploading results to the dashboard, a full vector of all results on individual runs is uploaded, so that statistics (e.g. std dev) are visible in the dashboard. Fixes https://github.com/domokit/devtools/issues/54. R=qsr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/574e2347ec780280488c5ef64a803d5c33f06c4d

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : Address Ben's comments. #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+172 lines, -69 lines)			Patch
M	mojo/devtools/common/devtoolslib/benchmark.py	View		3 chunks	+18 lines, -8 lines	0 comments	Download
M	mojo/devtools/common/devtoolslib/perf_dashboard.py	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
M	mojo/devtools/common/devtoolslib/perf_dashboard_unittest.py	View		1 chunk	+23 lines, -0 lines	0 comments	Download
M	mojo/devtools/common/mojo_benchmark	View	1 2	2 chunks	+122 lines, -61 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

qsr

LGTM wiht nits. https://codereview.chromium.org/1433693004/diff/20001/mojo/devtools/common/mojo_benchmark File mojo/devtools/common/mojo_benchmark (right): https://codereview.chromium.org/1433693004/diff/20001/mojo/devtools/common/mojo_benchmark#newcode85 mojo/devtools/common/mojo_benchmark:85: print '%10.4f' % results[measurement['spec']][0] Why is ...

5 years, 1 month ago (2015-11-10 17:05:27 UTC) #2

ppi

https://codereview.chromium.org/1433693004/diff/20001/mojo/devtools/common/mojo_benchmark File mojo/devtools/common/mojo_benchmark (right): https://codereview.chromium.org/1433693004/diff/20001/mojo/devtools/common/mojo_benchmark#newcode85 mojo/devtools/common/mojo_benchmark:85: print '%10.4f' % results[measurement['spec']][0] On 2015/11/10 17:05:27, qsr wrote: ...

5 years, 1 month ago (2015-11-10 18:00:19 UTC) #3

ppi

5 years, 1 month ago (2015-11-10 18:01:00 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
574e2347ec780280488c5ef64a803d5c33f06c4d (presubmit successful).

Expand Messages | Collapse Messages