Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 1433663002: Do not print stack-trace for OOM when GC is in progress. (Closed)

Created:
5 years, 1 month ago by ulan
Modified:
5 years, 1 month ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Do not print stack-trace for OOM when GC is in progress. BUG=chromium:553051 LOG=NO Committed: https://crrev.com/d763c7d0899ea25f644ac738bb4f858457835e68 Cr-Commit-Position: refs/heads/master@{#31877}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M src/heap/heap.cc View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
ulan
I decided to just disable stack traces for OOM in GC. We will still get ...
5 years, 1 month ago (2015-11-09 10:19:15 UTC) #2
Jarin
lgtm. I think it is ok to omit regression test for the OOM case.
5 years, 1 month ago (2015-11-09 10:22:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1433663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1433663002/1
5 years, 1 month ago (2015-11-09 10:28:58 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-09 11:06:45 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-09 11:07:12 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d763c7d0899ea25f644ac738bb4f858457835e68
Cr-Commit-Position: refs/heads/master@{#31877}

Powered by Google App Engine
This is Rietveld 408576698