Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1015)

Unified Diff: tools/dom/src/EventStreamProvider.dart

Issue 143363011: First pass at cleaning up html lib warnings from the analyzer. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/dom/src/EventStreamProvider.dart
diff --git a/tools/dom/src/EventStreamProvider.dart b/tools/dom/src/EventStreamProvider.dart
index 2e787bd5ff986025ed32044bed10ad67e2f1fbcc..85b4d78cb383a32b98838a3889b2c3c1c62129f1 100644
--- a/tools/dom/src/EventStreamProvider.dart
+++ b/tools/dom/src/EventStreamProvider.dart
@@ -223,13 +223,14 @@ class _EventStreamSubscription<T extends Event> extends StreamSubscription<T> {
_tryResume();
}
- void cancel() {
- if (_canceled) return;
+ Future cancel() {
+ if (_canceled) return null;
blois 2014/02/06 16:57:32 Should return new Future.value(null).
Emily Fortuna 2014/02/06 18:39:00 Does this mean the docs for this method should be
blois 2014/02/06 18:54:27 Ah! I was only looking at the implementation. Look
_unlisten();
// Clear out the target to indicate this is complete.
_target = null;
_onData = null;
+ return null;
}
bool get _canceled => _target == null;

Powered by Google App Engine
This is Rietveld 408576698