Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Unified Diff: sdk/lib/html/dart2js/html_dart2js.dart

Issue 143363011: First pass at cleaning up html lib warnings from the analyzer. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
Index: sdk/lib/html/dart2js/html_dart2js.dart
diff --git a/sdk/lib/html/dart2js/html_dart2js.dart b/sdk/lib/html/dart2js/html_dart2js.dart
index 4021b1824e74939eb54804cbfc6dc760b386817a..4227a8363f47d21f7eba93d6d2b779871cb754ed 100644
--- a/sdk/lib/html/dart2js/html_dart2js.dart
+++ b/sdk/lib/html/dart2js/html_dart2js.dart
@@ -32418,13 +32418,14 @@ class _EventStreamSubscription<T extends Event> extends StreamSubscription<T> {
_tryResume();
}
- void cancel() {
- if (_canceled) return;
+ Future cancel() {
+ if (_canceled) return null;
_unlisten();
// Clear out the target to indicate this is complete.
_target = null;
_onData = null;
+ return null;
}
bool get _canceled => _target == null;
@@ -34051,7 +34052,7 @@ class _KeyboardEventHandler extends EventStreamProvider<KeyEvent> {
* KeyboardEvent controller.
*/
_KeyboardEventHandler(this._type): super(_EVENT_TYPE),
- _stream = new _CustomKeyEventStreamImpl('event');
+ _stream = new _CustomKeyEventStreamImpl('event'), _target = null;
/**
* Hook up all event listeners under the covers so we can estimate keycodes

Powered by Google App Engine
This is Rietveld 408576698