Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Unified Diff: sdk/lib/_internal/lib/constant_map.dart

Issue 143363011: First pass at cleaning up html lib warnings from the analyzer. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sdk/lib/_internal/lib/js_helper.dart » ('j') | sdk/lib/_internal/lib/js_helper.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/lib/constant_map.dart
diff --git a/sdk/lib/_internal/lib/constant_map.dart b/sdk/lib/_internal/lib/constant_map.dart
index 398d37cf339db2f1e8d8035d6f7d6c5a569b1996..80b6705483699e4bf1989140f76b45bbcb587c8e 100644
--- a/sdk/lib/_internal/lib/constant_map.dart
+++ b/sdk/lib/_internal/lib/constant_map.dart
@@ -25,10 +25,10 @@ abstract class ConstantMap<K, V> implements Map<K, V> {
// is shortcut by the compiler.
class ConstantStringMap<K, V> extends ConstantMap<K, V>
implements _symbol_dev.EfficientLength {
- final int length;
+ final int length = 0;
Emily Fortuna 2014/02/06 01:38:16 not sure why fixing this file our problem, but it
blois 2014/02/06 16:57:32 I'd probably split this one out to a separate CL.
// A constant map is backed by a JavaScript object.
- final _jsObject;
- final List<K> _keys;
+ final _jsObject = null;
+ final List<K> _keys = null;
bool containsValue(V needle) {
return values.any((V value) => value == needle);
@@ -62,7 +62,7 @@ class ConstantStringMap<K, V> extends ConstantMap<K, V>
// This class has no constructor. This is on purpose since the instantiation
// is shortcut by the compiler.
class ConstantProtoMap<K, V> extends ConstantStringMap<K, V> {
- final V _protoValue;
+ final V _protoValue = null;
bool containsKey(Object key) {
if (key == '__proto__') return true;
@@ -86,7 +86,7 @@ class _ConstantMapKeyIterable<K> extends IterableBase<K> {
// is shortcut by the compiler.
class GeneralConstantMap<K, V> extends ConstantMap<K, V> {
// [_jsData] holds a key-value pair list.
- final _jsData;
+ final _jsData = null;
// We cannot create the backing map on creation since hashCode interceptors
// have not been defined when constants are created.
« no previous file with comments | « no previous file | sdk/lib/_internal/lib/js_helper.dart » ('j') | sdk/lib/_internal/lib/js_helper.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698