Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 143363007: Moving home and pillar pages to public folder (Closed)

Created:
6 years, 11 months ago by mkearney1
Modified:
6 years, 11 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, vsevik, yurys, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, chromium-apps-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Visibility:
Public.

Description

Moving home and pillar pages to public folder Hopefully we can open the pages from public. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246634

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removed pillar.html #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/common/extensions/docs/templates/json/content_providers.json View 1 chunk +7 lines, -7 lines 0 comments Download
A + chrome/common/extensions/docs/templates/public/home/devtools-pillar.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/common/extensions/docs/templates/public/home/index.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/common/extensions/docs/templates/public/home/multi-device-pillar.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/common/extensions/docs/templates/public/home/platform-pillar.html View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
mkearney1
Ben, I'm still sometimes seeing this error (not sure if related): mkearney@mkearney:~/chromium-new/src/chrome/common/extensions/docs/server2$ ERROR 2014-01-23 03:10:42,433 ...
6 years, 11 months ago (2014-01-23 03:20:03 UTC) #1
not at google - send to devlin
I don't know what the error is about but it shouldn't be related. LGTM but ...
6 years, 11 months ago (2014-01-23 03:38:59 UTC) #2
mkearney1
That page was uploaded in error! It's an old file from way back when. Good ...
6 years, 11 months ago (2014-01-23 04:07:45 UTC) #3
mkearney1
That page was uploaded in error! It's an old file from way back when. Good ...
6 years, 11 months ago (2014-01-23 04:07:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkearney@chromium.org/143363007/100001
6 years, 11 months ago (2014-01-23 04:08:34 UTC) #5
mkearney1
6 years, 11 months ago (2014-01-23 04:08:38 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=193770
6 years, 11 months ago (2014-01-23 05:44:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkearney@chromium.org/143363007/100001
6 years, 11 months ago (2014-01-23 16:33:47 UTC) #8
commit-bot: I haz the power
6 years, 11 months ago (2014-01-23 17:47:40 UTC) #9
Message was sent while issue was closed.
Change committed as 246634

Powered by Google App Engine
This is Rietveld 408576698