Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Unified Diff: Source/core/rendering/svg/SVGRenderSupport.cpp

Issue 143363004: Fix ASSERT failure in RenderGeomtryMap for SVGs (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/svg/SVGRenderSupport.cpp
diff --git a/Source/core/rendering/svg/SVGRenderSupport.cpp b/Source/core/rendering/svg/SVGRenderSupport.cpp
index 99871c7b9142b52b5a8a6b59b4f5d26958c7adba..ef38ba008e9e4320ba619084c1860ed227a7bd6a 100644
--- a/Source/core/rendering/svg/SVGRenderSupport.cpp
+++ b/Source/core/rendering/svg/SVGRenderSupport.cpp
@@ -67,8 +67,6 @@ void SVGRenderSupport::computeFloatRectForRepaint(const RenderObject* object, co
void SVGRenderSupport::mapLocalToContainer(const RenderObject* object, const RenderLayerModelObject* repaintContainer, TransformState& transformState, bool* wasFixed)
{
- transformState.applyTransform(object->localToParentTransform());
-
RenderObject* parent = object->parent();
// At the SVG/HTML boundary (aka RenderSVGRoot), we apply the localToBorderBoxTransform
@@ -77,6 +75,8 @@ void SVGRenderSupport::mapLocalToContainer(const RenderObject* object, const Ren
if (parent->isSVGRoot())
transformState.applyTransform(toRenderSVGRoot(parent)->localToBorderBoxTransform());
+ transformState.applyTransform(object->localToParentTransform());
fs 2014/01/21 09:07:57 This doesn't look right to me - I take it that in
Stephen Chennney 2014/01/21 22:12:11 I think that, like me, you are confused by the amb
+
MapCoordinatesFlags mode = UseTransforms;
parent->mapLocalToContainer(repaintContainer, transformState, mode, wasFixed);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698